Subject: Re: [PATCH net-next] net: stmmac: Populate missing callbacks in HWIF initialization

From: Corentin Labbe <[email-masked]>
Date: Fri, 18 May 2018 16:25:36 +0200

On Thu, May 17, 2018 at 10:57:28AM +0100, Jose Abreu wrote:
> Some HW specific setusp, like sun8i, do not populate all the necessary
> callbacks, which is what HWIF helpers were expecting.
> 
> Fix this by always trying to get the generic helpers and populate them
> if they were not previously populated by HW specific setup.
> 
> Signed-off-by: Jose Abreu <[email-masked]>
> Fixes: 5f0456b43140 ("net: stmmac: Implement logic to automatically
> select HW Interface")
> Reported-by: Corentin Labbe <[email-masked]>
> Cc: Corentin Labbe <[email-masked]>
> Cc: David S. Miller <[email-masked]>
> Cc: Joao Pinto <[email-masked]>
> Cc: Giuseppe Cavallaro <[email-masked]>
> Cc: Alexandre Torgue <[email-masked]>
> ---
> Hi Corentin,
> 
> Please check if this patch makes sun8i work again.
> 
> Thanks and Best Regards,
> Jose Miguel Abreu
> ---

Hello

Tested-by: Corentin Labbe <[email-masked]>

Thanks for the quick fix.

Note that this patch conflict with your next v3 serie

Regards