From: Jesper Dangaard Brouer <brouer@redhat•com>
To: netdev@vger•kernel.org, Daniel Borkmann <borkmann@iogearbox•net>,
Alexei Starovoitov <alexei.starovoitov@gmail•com>,
Jesper Dangaard Brouer <brouer@redhat•com>
Cc: "Christoph Hellwig" <hch@infradead•org>,
BjörnTöpel <bjorn.topel@intel•com>,
"Magnus Karlsson" <magnus.karlsson@intel•com>,
makita.toshiaki@lab•ntt.co.jp
Subject: Re: [bpf-next V4 PATCH 5/8] xdp: introduce xdp_return_frame_rx_napi
Date: Fri, 18 May 2018 22:46:06 +0200 [thread overview]
Message-ID: <20180518224606.1dd2edc7@redhat.com> (raw)
In-Reply-To: <152665049699.21055.13036051815851476324.stgit@firesoul>
On Fri, 18 May 2018 15:34:57 +0200
Jesper Dangaard Brouer <brouer@redhat•com> wrote:
> When sending an xdp_frame through xdp_do_redirect call, then error
> cases can happen where the xdp_frame needs to be dropped, and
> returning an -errno code isn't sufficient/possible any-longer
> (e.g. for cpumap case). This is already fully supported, by simply
> calling xdp_return_frame.
>
> This patch is an optimization, which provides xdp_return_frame_rx_napi,
> which is a faster variant for these error cases. It take advantage of
> the protection provided by XDP RX running under NAPI protection.
>
> This change is mostly relevant for drivers using the page_pool
> allocator as it can take advantage of this. (Tested with mlx5).
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat•com>
Ups, forgot my SoB... hope it's sufficient to add it this way.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2018-05-18 20:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 13:34 [bpf-next V4 PATCH 0/8] xdp: introduce bulking for ndo_xdp_xmit API Jesper Dangaard Brouer
2018-05-18 13:34 ` [bpf-next V4 PATCH 1/8] bpf: devmap introduce dev_map_enqueue Jesper Dangaard Brouer
2018-05-23 9:34 ` Daniel Borkmann
2018-05-23 11:12 ` Jesper Dangaard Brouer
2018-05-18 13:34 ` [bpf-next V4 PATCH 2/8] bpf: devmap prepare xdp frames for bulking Jesper Dangaard Brouer
2018-05-23 9:54 ` Daniel Borkmann
2018-05-23 10:29 ` Jesper Dangaard Brouer
2018-05-23 10:45 ` Daniel Borkmann
2018-05-23 10:38 ` Jesper Dangaard Brouer
2018-05-18 13:34 ` [bpf-next V4 PATCH 3/8] xdp: add tracepoint for devmap like cpumap have Jesper Dangaard Brouer
2018-05-23 14:24 ` John Fastabend
2018-05-23 15:04 ` Jesper Dangaard Brouer
2018-05-18 13:34 ` [bpf-next V4 PATCH 4/8] samples/bpf: xdp_monitor use tracepoint xdp:xdp_devmap_xmit Jesper Dangaard Brouer
2018-05-18 13:34 ` [bpf-next V4 PATCH 5/8] xdp: introduce xdp_return_frame_rx_napi Jesper Dangaard Brouer
2018-05-18 20:46 ` Jesper Dangaard Brouer [this message]
2018-05-18 13:35 ` [bpf-next V4 PATCH 6/8] xdp: change ndo_xdp_xmit API to support bulking Jesper Dangaard Brouer
2018-05-23 14:42 ` John Fastabend
2018-05-23 15:27 ` Jesper Dangaard Brouer
2018-05-18 13:35 ` [bpf-next V4 PATCH 7/8] xdp/trace: extend tracepoint in devmap with an err Jesper Dangaard Brouer
2018-05-18 20:49 ` Jesper Dangaard Brouer
2018-05-18 13:35 ` [bpf-next V4 PATCH 8/8] samples/bpf: xdp_monitor use err code from tracepoint xdp:xdp_devmap_xmit Jesper Dangaard Brouer
2018-05-18 20:48 ` Jesper Dangaard Brouer
2018-05-23 9:24 ` [bpf-next V4 PATCH 0/8] xdp: introduce bulking for ndo_xdp_xmit API Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518224606.1dd2edc7@redhat.com \
--to=brouer@redhat$(echo .)com \
--cc=alexei.starovoitov@gmail$(echo .)com \
--cc=bjorn.topel@intel$(echo .)com \
--cc=borkmann@iogearbox$(echo .)net \
--cc=hch@infradead$(echo .)org \
--cc=magnus.karlsson@intel$(echo .)com \
--cc=makita.toshiaki@lab$(echo .)ntt.co.jp \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox