From: "Michael S. Tsirkin" <mst@redhat•com>
To: Jiri Pirko <jiri@resnulli•us>
Cc: Sridhar Samudrala <sridhar.samudrala@intel•com>,
stephen@networkplumber•org, davem@davemloft•net,
netdev@vger•kernel.org,
virtualization@lists•linux-foundation.org,
virtio-dev@lists•oasis-open.org, jesse.brandeburg@intel•com,
alexander.h.duyck@intel•com, kubakici@wp•pl, jasowang@redhat•com,
loseweigh@gmail•com, aaron.f.brown@intel•com,
anjali.singhai@intel•com
Subject: Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework
Date: Tue, 22 May 2018 22:54:35 +0300 [thread overview]
Message-ID: <20180522204216-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180522173844.GP2149@nanopsycho>
On Tue, May 22, 2018 at 07:38:44PM +0200, Jiri Pirko wrote:
> >> >> In private
> >> >> flag. I don't see no reason to break this pattern here.
> >> >
> >> >Other masters are setup from userspace, this one is set up automatically
> >> >by kernel. So the bar is higher, we need an interface that existing
> >> >userspace knows about. We can't just say "oh if userspace set this up
> >> >it should know to skip lowerdevs".
> >> >
> >> >Otherwise multiple interfaces with same mac tend to confuse userspace.
> >>
> >> No difference, really.
> >> Regardless who does the setup, and independent userspace deamon should
> >> react accordingly.
> >
> >If the deamon does the setup itself, it's reasonable to require that it
> >learns about new flags each time we add a new driver. If it doesn't,
> >then I think it's less reasonable.
>
> No need. The "IFLA_MASTER" attr is always there to be looked at. That is
> enough.
Oh so if it has an master, skip it? Sorry, I misunderstood what you were
saying earlier.
Thanks, this makes sense to me.
--
MST
next prev parent reply other threads:[~2018-05-22 19:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 2:06 [PATCH net-next v11 0/5] Enable virtio_net to act as a standby for a passthru device Sridhar Samudrala
2018-05-22 2:06 ` [PATCH net-next v11 1/5] net: Introduce generic failover module Sridhar Samudrala
2018-05-22 2:06 ` [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework Sridhar Samudrala
2018-05-22 9:06 ` Jiri Pirko
2018-05-22 9:08 ` Jiri Pirko
2018-05-22 13:12 ` Michael S. Tsirkin
2018-05-22 13:14 ` Jiri Pirko
2018-05-22 13:17 ` Michael S. Tsirkin
2018-05-22 13:26 ` Jiri Pirko
2018-05-22 13:39 ` Michael S. Tsirkin
2018-05-22 15:13 ` Jiri Pirko
2018-05-22 15:32 ` Michael S. Tsirkin
2018-05-22 15:45 ` Jiri Pirko
2018-05-22 16:52 ` Michael S. Tsirkin
2018-05-22 17:38 ` Jiri Pirko
2018-05-22 19:54 ` Michael S. Tsirkin [this message]
2018-05-22 15:28 ` Samudrala, Sridhar
2018-05-22 15:36 ` Shepherd request (P83): Multipath TCP: Present Use Cases and an Upstream Future Jiri Pirko
2018-05-22 15:46 ` Michael S. Tsirkin
2018-05-22 16:12 ` [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework Jiri Pirko
2018-05-22 20:54 ` Samudrala, Sridhar
2018-05-23 6:27 ` Jiri Pirko
2018-05-23 16:16 ` Samudrala, Sridhar
2018-05-22 2:06 ` [PATCH net-next v11 3/5] net: Introduce net_failover driver Sridhar Samudrala
2018-05-22 8:59 ` Jiri Pirko
2018-05-22 2:06 ` [PATCH net-next v11 4/5] virtio_net: Introduce VIRTIO_NET_F_STANDBY feature bit Sridhar Samudrala
2018-05-22 2:06 ` [PATCH net-next v11 5/5] virtio_net: Extend virtio to use VF datapath when available Sridhar Samudrala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522204216-mutt-send-email-mst@kernel.org \
--to=mst@redhat$(echo .)com \
--cc=aaron.f.brown@intel$(echo .)com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=anjali.singhai@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jasowang@redhat$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kubakici@wp$(echo .)pl \
--cc=loseweigh@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sridhar.samudrala@intel$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=virtio-dev@lists$(echo .)oasis-open.org \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox