Subject: Re: [PATCH bpf-next 04/11] bpf: show prog and map id in fdinfo

From: Jesper Dangaard Brouer <[email-masked]>
Date: Wed, 30 May 2018 19:15:29 +0200

On Wed, 30 May 2018 09:15:25 -0700
Song Liu <[email-masked]> wrote:

> On Tue, May 29, 2018 at 12:55 PM, Daniel Borkmann <[email-masked]> wrote:
> > On 05/29/2018 07:27 PM, Jesper Dangaard Brouer wrote:  
> >> On Mon, 28 May 2018 02:43:37 +0200
> >> Daniel Borkmann <[email-masked]> wrote:
> >>  
> >>> Its trivial and straight forward to expose it for scripts that can
> >>> then use it along with bpftool in order to inspect an individual
> >>> application's used maps and progs. Right now we dump some basic
> >>> information in the fdinfo file but with the help of the map/prog
> >>> id full introspection becomes possible now.
> >>>
> >>> Signed-off-by: Daniel Borkmann <[email-masked]>
> >>> Acked-by: Alexei Starovoitov <[email-masked]>  
> 
> Acked-by: Song Liu <[email-masked]>
> 
> >>
> >> AFAICR iproute uses this proc fdinfo, for pinned maps.  Have you tested
> >> if this change is handled gracefully by tc ?  
> >
> > Yep, it works just fine, I also tested it before submission.  

Sounds good.

Acked-by: Jesper Dangaard Brouer <[email-masked]>

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer