From: Ido Schimmel <idosch@idosch•org>
To: dsahern@kernel•org
Cc: netdev@vger•kernel.org, idosch@mellanox•com, jiri@mellanox•com,
jakub.kicinski@netronome•com, David Ahern <dsahern@gmail•com>
Subject: Re: [PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures
Date: Tue, 5 Jun 2018 08:56:47 +0300 [thread overview]
Message-ID: <20180605055647.GA24986@splinter.mtl.com> (raw)
In-Reply-To: <20180604221503.20329-4-dsahern@kernel.org>
On Mon, Jun 04, 2018 at 03:15:03PM -0700, dsahern@kernel•org wrote:
> From: David Ahern <dsahern@gmail•com>
>
> Return messages in extack for port split/unsplit errors. e.g.,
> $ devlink port split swp1s1 count 4
> Error: mlxsw_spectrum: Port cannot be split further.
> devlink answers: Invalid argument
>
> $ devlink port unsplit swp4
> Error: mlxsw_spectrum: Port was not split.
> devlink answers: Invalid argument
>
> Signed-off-by: David Ahern <dsahern@gmail•com>
Reviewed-by: Ido Schimmel <idosch@mellanox•com>
Thanks!
next prev parent reply other threads:[~2018-06-05 5:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 22:15 [PATCH net-next 0/3] devlink: Add extack messages for reload and port split/unsplit dsahern
2018-06-04 22:15 ` [PATCH net-next 1/3] devlink: Add extack to reload and port_{un,}split operations dsahern
2018-06-05 7:50 ` Jiri Pirko
2018-06-04 22:15 ` [PATCH net-next 2/3] netdevsim: Add extack error message for devlink reload dsahern
2018-06-04 22:47 ` Jakub Kicinski
2018-06-04 22:15 ` [PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures dsahern
2018-06-05 5:56 ` Ido Schimmel [this message]
2018-06-05 7:52 ` [PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures^[ Jiri Pirko
2018-06-05 8:05 ` [PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures? Ido Schimmel
2018-06-05 8:18 ` Jiri Pirko
2018-06-05 14:24 ` David Miller
2018-06-05 14:58 ` David Ahern
2018-06-05 15:05 ` David Miller
2018-06-05 15:05 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605055647.GA24986@splinter.mtl.com \
--to=idosch@idosch$(echo .)org \
--cc=dsahern@gmail$(echo .)com \
--cc=dsahern@kernel$(echo .)org \
--cc=idosch@mellanox$(echo .)com \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox