From: Kalle Valo <kvalo@codeaurora•org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor•com>
Cc: Igor Mitsyanko <imitsyanko@quantenna•com>,
Avinash Patil <avinashp@quantenna•com>,
Sergey Matyukevich <smatyukevich@quantenna•com>,
"David S. Miller" <davem@davemloft•net>,
linux-wireless@vger•kernel.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor•com>,
kernel-janitors@vger•kernel.org
Subject: Re: qtnfmac: fix NULL pointer dereference
Date: Mon, 18 Jun 2018 08:55:35 +0000 (UTC) [thread overview]
Message-ID: <20180618085535.6A8F160B13@smtp.codeaurora.org> (raw)
In-Reply-To: <20180601132408.GA2572@embeddedor.com>
"Gustavo A. R. Silva" <gustavo@embeddedor•com> wrote:
> In case *vif* is NULL at 655: if (!vif), the execution path jumps to
> label out, where *vif* is dereferenced at 679:
>
> if (vif->sta_state == QTNF_STA_CONNECTING)
>
> Fix this by immediately returning when *vif* is NULL instead of
> jumping to label out.
>
> Addresses-Coverity-ID: 1469567 ("Dereference after null check")
> Fixes: 480daa9cb62c ("qtnfmac: fix invalid STA state on EAPOL failure")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor•com>
> Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quanenna•com>
Patch applied to wireless-drivers.git, thanks.
c1e3f64f8738 qtnfmac: fix NULL pointer dereference
--
https://patchwork.kernel.org/patch/10443507/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2018-06-18 8:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 13:24 [PATCH] qtnfmac: fix NULL pointer dereference Gustavo A. R. Silva
2018-06-01 14:08 ` Sergey Matyukevich
2018-06-01 14:22 ` Gustavo A. R. Silva
2018-06-01 15:52 ` Kalle Valo
2018-06-18 8:55 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618085535.6A8F160B13@smtp.codeaurora.org \
--to=kvalo@codeaurora$(echo .)org \
--cc=avinashp@quantenna$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gustavo@embeddedor$(echo .)com \
--cc=imitsyanko@quantenna$(echo .)com \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=smatyukevich@quantenna$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox