Subject: Re: [PATCH v2 bpf-net] bpf: Change bpf_fib_lookup to return lookup status

From: Jesper Dangaard Brouer <[email-masked]>
Date: Fri, 22 Jun 2018 17:49:14 +0200

On Thu, 21 Jun 2018 10:09:36 -0700
Martin KaFai Lau <[email-masked]> wrote:

> On Wed, Jun 20, 2018 at 08:00:11PM -0700, [email-masked] wrote:
> > From: David Ahern <[email-masked]>
> > 
> > For ACLs implemented using either FIB rules or FIB entries, the BPF
> > program needs the FIB lookup status to be able to drop the packet.
> > Since the bpf_fib_lookup API has not reached a released kernel yet,
> > change the return code to contain an encoding of the FIB lookup
> > result and return the nexthop device index in the params struct.
> > 
> > In addition, inform the BPF program of any post FIB lookup reason as
> > to why the packet needs to go up the stack.
> > 
> > The fib result for unicast routes must have an egress device, so remove
> > the check that it is non-NULL.  
> Acked-by: Martin KaFai Lau <[email-masked]>

Acked-by: Jesper Dangaard Brouer <[email-masked]>

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer