Subject: Re: brcmsmac: fix wrap around in conversion from constant to s16

From: Kalle Valo <[email-masked]>
Date: Wed, 27 Jun 2018 15:57:07 +0000 (UTC)

Stefan Agner <[email-masked]> wrote:

> The last value in the log_table wraps around to a negative value
> since s16 has a value range of -32768 to 32767. This is not what
> the table intends to represent. Use the closest positive value
> 32767.
> 
> This fixes a warning seen with clang:
> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_qmath.c:216:2: warning:
>       implicit conversion from 'int' to 's16' (aka 'short') changes
> value from 32768
>       to -32768 [-Wconstant-conversion]
>         32768
>         ^~~~~
> 1 warning generated.
> 
> Fixes: 4c0bfeaae9f9 ("brcmsmac: fix array out-of-bounds access in qm_log10")
> Cc: Tobias Regnery <[email-masked]>
> Signed-off-by: Stefan Agner <[email-masked]>

Patch applied to wireless-drivers-next.git, thanks.

c9a61469fc97 brcmsmac: fix wrap around in conversion from constant to s16

-- 
https://patchwork.kernel.org/patch/10468755/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches