Subject: Re: [RFC bpf-next 2/6] net: xdp: RX meta data infrastructure

From: Jesper Dangaard Brouer <[email-masked]>
Date: Wed, 27 Jun 2018 16:15:17 +0200

On Tue, 26 Jun 2018 19:46:11 -0700
Saeed Mahameed <[email-masked]> wrote:

> diff --git a/include/net/xdp.h b/include/net/xdp.h
> index 2deea7166a34..afe302613ae1 100644
> --- a/include/net/xdp.h
> +++ b/include/net/xdp.h
> @@ -138,6 +138,12 @@ xdp_set_data_meta_invalid(struct xdp_buff *xdp)
>  	xdp->data_meta = xdp->data + 1;
>  }
>  
> +static __always_inline void
> +xdp_reset_data_meta(struct xdp_buff *xdp)
> +{
> +	xdp->data_meta = xdp->data_hard_start;
> +}

This is WRONG ... it should be:

 xdp->data_meta = xdp->data;

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer