Subject: Re: [PATCH net-next 01/10] r8169: add basic phylib support

From: Andrew Lunn <[email-masked]>
Date: Mon, 2 Jul 2018 23:02:39 +0200

> +static int r8169_mdio_read_reg(struct mii_bus *mii_bus, int phyaddr, int phyreg)
> +{
> +	struct rtl8169_private *tp = mii_bus->priv;
> +
> +	return rtl_readphy(tp, phyreg);

So there is no support for phyaddr?

It would be better to trap the phyaddr which are not supported and
return 0xffff.

       Andrew