From: Stefano Brivio <sbrivio@redhat•com>
To: dsahern@kernel•org
Cc: netdev@vger•kernel.org, eric.dumazet@gmail•com,
David Ahern <dsahern@gmail•com>
Subject: Re: [PATCH net] net/ipv6: Do not allow device only routes via the multipath API
Date: Fri, 13 Jul 2018 13:28:45 +0200 [thread overview]
Message-ID: <20180713132845.64854ff3@epycfail> (raw)
In-Reply-To: <20180712214823.6917-1-dsahern@kernel.org>
On Thu, 12 Jul 2018 14:48:23 -0700
dsahern@kernel•org wrote:
> @@ -4388,6 +4388,13 @@ static int ip6_route_multipath_add(struct fib6_config *cfg,
> rt = NULL;
> goto cleanup;
> }
> + if (!rt6_qualify_for_ecmp(rt)) {
> + err = EINVAL;
Shouldn't this be -EINVAL, just for consistency? E.g. we might return a
-ENOMEM from ip6_route_info_append(), etc.
--
Stefano
next prev parent reply other threads:[~2018-07-13 11:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 21:48 [PATCH net] net/ipv6: Do not allow device only routes via the multipath API dsahern
2018-07-13 11:28 ` Stefano Brivio [this message]
2018-07-13 14:45 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180713132845.64854ff3@epycfail \
--to=sbrivio@redhat$(echo .)com \
--cc=dsahern@gmail$(echo .)com \
--cc=dsahern@kernel$(echo .)org \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox