From: Russell King - ARM Linux <linux@armlinux•org.uk>
To: Gregory CLEMENT <gregory.clement@bootlin•com>
Cc: "David S. Miller" <davem@davemloft•net>,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
"Andrew Lunn" <andrew@lunn•ch>,
"Jason Cooper" <jason@lakedaemon•net>,
"Antoine Tenart" <antoine.tenart@bootlin•com>,
"Maxime Chevallier" <maxime.chevallier@bootlin•com>,
"Nadav Haklai" <nadavh@marvell•com>,
"Yelena Krivosheev" <yelena@marvell•com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin•com>,
"Miquèl Raynal" <miquel.raynal@bootlin•com>,
"Marcin Wojtas" <mw@semihalf•com>,
"Dmitri Epshtein" <dima@marvell•com>,
linux-arm-kernel@lists•infradead.org,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail•com>
Subject: Re: [PATCH net-next v2 3/7] net: mvneta: increase number of buffers in RX and TX queue
Date: Fri, 13 Jul 2018 20:17:20 +0100 [thread overview]
Message-ID: <20180713191720.GA17271@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20180713161841.11202-4-gregory.clement@bootlin.com>
On Fri, Jul 13, 2018 at 06:18:37PM +0200, Gregory CLEMENT wrote:
> From: Yelena Krivosheev <yelena@marvell•com>
>
> The initial values were too small leading to poor performance when using
> the software buffer management.
What does this do to latency when a large transfer is also ongoing
(iow, the classic bufferbloat issue) ?
>
> Signed-off-by: Yelena Krivosheev <yelena@marvell•com>
> [gregory: extract from a larger patch]
> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin•com>
> ---
> drivers/net/ethernet/marvell/mvneta.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> index f4e3943a745d..c22df28b07c8 100644
> --- a/drivers/net/ethernet/marvell/mvneta.c
> +++ b/drivers/net/ethernet/marvell/mvneta.c
> @@ -295,10 +295,10 @@
> #define MVNETA_RSS_LU_TABLE_SIZE 1
>
> /* Max number of Rx descriptors */
> -#define MVNETA_MAX_RXD 128
> +#define MVNETA_MAX_RXD 512
>
> /* Max number of Tx descriptors */
> -#define MVNETA_MAX_TXD 532
> +#define MVNETA_MAX_TXD 1024
>
> /* Max number of allowed TCP segments for software TSO */
> #define MVNETA_MAX_TSO_SEGS 100
> --
> 2.18.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists•infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up
According to speedtest.net: 13Mbps down 490kbps up
next prev parent reply other threads:[~2018-07-13 19:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 16:18 [PATCH net-next v2 0/7] A fix and a few improvements on mvneta Gregory CLEMENT
2018-07-13 16:18 ` [PATCH net-next v2 1/7] net: ethernet: mvneta: Fix napi structure mixup on armada 3700 Gregory CLEMENT
2018-07-13 16:18 ` [PATCH net-next v2 2/7] net: mvneta: remove data pointer usage from device_node structure Gregory CLEMENT
2018-07-13 16:18 ` [PATCH net-next v2 3/7] net: mvneta: increase number of buffers in RX and TX queue Gregory CLEMENT
2018-07-13 19:17 ` Russell King - ARM Linux [this message]
2018-07-18 15:37 ` Gregory CLEMENT
2018-07-18 20:55 ` Dave Taht
2018-07-13 16:18 ` [PATCH net-next v2 4/7] net: mvneta: discriminate error cause for missed packet Gregory CLEMENT
2018-07-13 16:18 ` [PATCH net-next v2 5/7] net: mvneta: Allocate page for the descriptor Gregory CLEMENT
2018-07-14 1:23 ` David Miller
2018-07-13 16:18 ` [PATCH net-next v2 6/7] net: mvneta: Verify hardware checksum only when offload checksum feature is set Gregory CLEMENT
2018-07-13 16:18 ` [PATCH net-next v2 7/7] net: mvneta: Improve the buffer allocation method for SWBM Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180713191720.GA17271@n2100.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=andrew@lunn$(echo .)ch \
--cc=antoine.tenart@bootlin$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dima@marvell$(echo .)com \
--cc=gregory.clement@bootlin$(echo .)com \
--cc=jason@lakedaemon$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=miquel.raynal@bootlin$(echo .)com \
--cc=mw@semihalf$(echo .)com \
--cc=nadavh@marvell$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=yelena@marvell$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox