From: Jakub Kicinski <jakub.kicinski@netronome•com>
To: Vinicius Costa Gomes <vinicius.gomes@intel•com>
Cc: Jiri Pirko <jiri@resnulli•us>,
netdev@vger•kernel.org, jesus.sanchez-palencia@intel•com,
tglx@linutronix•de, jan.altenberg@linutronix•de,
henrik@austad•us, richardcochran@gmail•com,
levi.pearson@harman•com, jhs@mojatatu•com,
xiyou.wangcong@gmail•com
Subject: Re: [RFC net-next v1 1/1] net/sched: Introduce the taprio scheduler
Date: Mon, 16 Jul 2018 14:06:20 -0700 [thread overview]
Message-ID: <20180716140620.4c171c6d@cakuba.lan> (raw)
In-Reply-To: <87va9fgl3g.fsf@intel.com>
On Mon, 16 Jul 2018 10:13:23 -0700, Vinicius Costa Gomes wrote:
> Hi Jiri,
>
> Jiri Pirko <jiri@resnulli•us> writes:
>
> [...]
>
> >>
> >>gates.sched
> >
> > Any particular reason this has to be in file and not on the cmdline?
>
> The idea here was to keep longer schedules more manageable. And during
> testing I found it more ergonomic to have a file.
>
> It also has the advantage that the file can be reused by other tools,
> dump-classifier (awful name, I admit), included in that github gist, is
> one example, it uses the schedule (and some more information) to
> calculate which packets would fall outside their "windows" in a pcap
> dump.
>
> Anyway, if there are use cases that having the schedule in the command
> line helps, I would be happy to add it.
FWIW there is some precedent in cls_bpf/act_bpf for allowing specifying
potentially long sequences both in command line and as a file (cBPF
filters in that case - see man tc-bpf bytecode and bytecode-file).
prev parent reply other threads:[~2018-07-16 21:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-14 0:05 [RFC net-next v1 0/1] net/sched: Introduce the taprio scheduler Vinicius Costa Gomes
2018-07-14 0:05 ` [RFC net-next v1 1/1] " Vinicius Costa Gomes
2018-07-14 6:45 ` Jiri Pirko
2018-07-16 17:13 ` Vinicius Costa Gomes
2018-07-16 21:06 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716140620.4c171c6d@cakuba.lan \
--to=jakub.kicinski@netronome$(echo .)com \
--cc=henrik@austad$(echo .)us \
--cc=jan.altenberg@linutronix$(echo .)de \
--cc=jesus.sanchez-palencia@intel$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=levi.pearson@harman$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=richardcochran@gmail$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=vinicius.gomes@intel$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox