Subject: Re: [PATCH next] bonding: pass link-local packets to bonding master also.

From: Stephen Hemminger <[email-masked]>
Date: Mon, 16 Jul 2018 17:43:49 -0700

On Mon, 16 Jul 2018 16:57:22 -0700
Mahesh Bandewar (महेश बंडेवार) <[email-masked]> wrote:

> On Mon, Jul 16, 2018 at 4:33 PM, Stephen Hemminger
> <[email-masked]> wrote:
> > On Sun, 15 Jul 2018 18:12:46 -0700
> > Mahesh Bandewar <[email-masked]> wrote:
> >  
> >> From: Mahesh Bandewar <[email-masked]>
> >>
> >> Commit b89f04c61efe ("bonding: deliver link-local packets with
> >> skb->dev set to link that packets arrived on") changed the behavior
> >> of how link-local-multicast packets are processed. The change in
> >> the behavior broke some legacy use cases where these packets are
> >> expected to arrive on bonding master device also.
> >>
> >> This patch passes the packet to the stack with the link it arrived
> >> on as well as passes to the bonding-master device to preserve the
> >> legacy use case.
> >>
> >> Reported-by: Michal Soltys <[email-masked]>
> >> Signed-off-by: Mahesh Bandewar <[email-masked]>  
> >
> > Thanks for fixing this.
> >
> > Why not add a Fixes: tag instead of just talking about the commit?
> > That helps the stable maintainers know which versions of the kernel
> > need the patch.  
> Well, I thought about it. It's definitely 'related' but not sure it
> 'fixes' in true sense. It definitely fixes the broken legacy case
> though. Is that sufficient to add 'fixes' tag?

The previous commit caused a regression. your change fixes the regression