Subject: Re: [PATCH net-next 0/7] net: Support Wake-on-LAN using filters

From: Andrew Lunn <[email-masked]>
Date: Tue, 17 Jul 2018 18:51:49 +0200

On Tue, Jul 17, 2018 at 09:28:52AM -0700, Florian Fainelli wrote:
> 
> 
> On 07/17/2018 09:21 AM, Andrew Lunn wrote:
> >>>> ethtool -s gphy wol f filters 0x2
> >>>
> >>> What does this 0x2 represent?
> >>
> >> 0x2 = bit 1 is set, which corresponds to the filter ID that was returned
> >> from the previous ethtool::rxnfc command invocation. If ethtool
> >> --config-nfc returned 3, then we would have used filters 0x8, etc.
> > 
> > It would be a simpler for the user if you could pass the filter IDs as
> > a list, and let ethtool do the shift and OR.
> 
> Sure, I can definitively add that, is a comma separator okay with you
> for that? E.g:
> 
> ethtool -s gphy wol f filters 0,1,2,3,4,5,6,7

Hi Florian

That looks good. But maybe check the man page for ethtool and see if
there is an established convention.

      Andrew