From: Stephen Hemminger <stephen@networkplumber•org>
To: josef@toxicpanda•com, axboe@kernel•dk, pablo@netfilter•org,
laforge@gnumonks•org
Cc: linux-block@vger•kernel.org, nbd@other•debian.org,
osmocom-net-gprs@lists•osmocom.org, netdev@vger•kernel.org,
Stephen Hemminger <sthemmin@microsoft•com>,
Stephen Hemminger <stephen@networkplumber•org>
Subject: [PATCH net-next 1/2] nbd: constify nla_policy
Date: Wed, 18 Jul 2018 09:32:43 -0700 [thread overview]
Message-ID: <20180718163244.1590-2-sthemmin@microsoft.com> (raw)
In-Reply-To: <20180718163244.1590-1-sthemmin@microsoft.com>
The netlink policy should be const like other drivers.
Signed-off-by: Stephen Hemminger <stephen@networkplumber•org>
---
drivers/block/nbd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 74a05561b620..e07401d3901d 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -1571,7 +1571,7 @@ static int find_free_cb(int id, void *ptr, void *data)
}
/* Netlink interface. */
-static struct nla_policy nbd_attr_policy[NBD_ATTR_MAX + 1] = {
+static const struct nla_policy nbd_attr_policy[NBD_ATTR_MAX + 1] = {
[NBD_ATTR_INDEX] = { .type = NLA_U32 },
[NBD_ATTR_SIZE_BYTES] = { .type = NLA_U64 },
[NBD_ATTR_BLOCK_SIZE_BYTES] = { .type = NLA_U64 },
@@ -1583,14 +1583,14 @@ static struct nla_policy nbd_attr_policy[NBD_ATTR_MAX + 1] = {
[NBD_ATTR_DEVICE_LIST] = { .type = NLA_NESTED},
};
-static struct nla_policy nbd_sock_policy[NBD_SOCK_MAX + 1] = {
+static const struct nla_policy nbd_sock_policy[NBD_SOCK_MAX + 1] = {
[NBD_SOCK_FD] = { .type = NLA_U32 },
};
/* We don't use this right now since we don't parse the incoming list, but we
* still want it here so userspace knows what to expect.
*/
-static struct nla_policy __attribute__((unused))
+static const struct nla_policy __attribute__((unused))
nbd_device_policy[NBD_DEVICE_ATTR_MAX + 1] = {
[NBD_DEVICE_INDEX] = { .type = NLA_U32 },
[NBD_DEVICE_CONNECTED] = { .type = NLA_U8 },
--
2.18.0
next prev parent reply other threads:[~2018-07-18 17:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 16:32 [PATCH net-next 0/2] constify nla_policy Stephen Hemminger
2018-07-18 16:32 ` Stephen Hemminger [this message]
2018-07-18 16:32 ` [PATCH net-next 2/2] gtp: " Stephen Hemminger
2018-07-20 19:34 ` [PATCH net-next 0/2] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718163244.1590-2-sthemmin@microsoft.com \
--to=stephen@networkplumber$(echo .)org \
--cc=axboe@kernel$(echo .)dk \
--cc=josef@toxicpanda$(echo .)com \
--cc=laforge@gnumonks$(echo .)org \
--cc=linux-block@vger$(echo .)kernel.org \
--cc=nbd@other$(echo .)debian.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=osmocom-net-gprs@lists$(echo .)osmocom.org \
--cc=pablo@netfilter$(echo .)org \
--cc=sthemmin@microsoft$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox