From: Bartosz Golaszewski <brgl@bgdev•pl>
To: Sekhar Nori <nsekhar@ti•com>, Kevin Hilman <khilman@kernel•org>,
Russell King <linux@armlinux•org.uk>,
Grygorii Strashko <grygorii.strashko@ti•com>,
"David S . Miller" <davem@davemloft•net>,
Srinivas Kandagatla <srinivas.kandagatla@linaro•org>,
Lukas Wunner <lukas@wunner•de>, Rob Herring <robh@kernel•org>,
Florian Fainelli <f.fainelli@gmail•com>,
Dan Carpenter <dan.carpenter@oracle•com>,
Ivan Khoronzhuk <ivan.khoronzhuk@linaro•org>,
David Lechner <david@lechnology•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Andrew Lunn <andrew@lunn•ch>
Cc: linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, linux-omap@vger•kernel.org,
netdev@vger•kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre•com>
Subject: [PATCH v2 1/3] net: fortify eth_platform_get_mac_address()
Date: Thu, 19 Jul 2018 10:20:26 +0200 [thread overview]
Message-ID: <20180719082028.26116-2-brgl@bgdev.pl> (raw)
In-Reply-To: <20180719082028.26116-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <bgolaszewski@baylibre•com>
We'll soon have more sources from which to read the MAC address in this
routine. Make sure the address is correct before returning it.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre•com>
Reviewed-by: Andrew Lunn <andrew@lunn•ch>
---
net/ethernet/eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
index ee28440f57c5..39af03894598 100644
--- a/net/ethernet/eth.c
+++ b/net/ethernet/eth.c
@@ -541,7 +541,7 @@ int eth_platform_get_mac_address(struct device *dev, u8 *mac_addr)
if (!addr)
addr = arch_get_platform_mac_address();
- if (!addr)
+ if (!addr || !is_valid_ether_addr(addr))
return -ENODEV;
ether_addr_copy(mac_addr, addr);
--
2.17.1
next prev parent reply other threads:[~2018-07-19 8:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 8:20 [PATCH v2 0/3] net: extend eth_platform_get_mac_address() Bartosz Golaszewski
2018-07-19 8:20 ` Bartosz Golaszewski [this message]
2018-07-19 8:20 ` [PATCH v2 2/3] net: add support for nvmem to eth_platform_get_mac_address() Bartosz Golaszewski
2018-07-19 8:48 ` Dan Carpenter
2018-07-19 8:57 ` Bartosz Golaszewski
2018-07-19 9:09 ` Dan Carpenter
2018-07-19 10:06 ` Bartosz Golaszewski
2018-07-19 12:37 ` Dan Carpenter
2018-07-19 15:35 ` Bartosz Golaszewski
2018-07-19 12:23 ` Russell King - ARM Linux
2018-07-19 8:20 ` [PATCH v2 3/3] net: add MTD support " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719082028.26116-2-brgl@bgdev.pl \
--to=brgl@bgdev$(echo .)pl \
--cc=andrew@lunn$(echo .)ch \
--cc=bgolaszewski@baylibre$(echo .)com \
--cc=dan.carpenter@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=david@lechnology$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=grygorii.strashko@ti$(echo .)com \
--cc=ivan.khoronzhuk@linaro$(echo .)org \
--cc=khilman@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=lukas@wunner$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nsekhar@ti$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=srinivas.kandagatla@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox