From: Nicholas Mc Guire <der.herr@hofr•at>
To: Marc Kleine-Budde <mkl@pengutronix•de>
Cc: Fabio Estevam <festevam@gmail•com>,
Nicholas Mc Guire <hofrat@osadl•org>,
Wolfram Sang <w.sang@pengutronix•de>,
Wolfgang Grandegger <wg@grandegger•com>,
"David S. Miller" <davem@davemloft•net>,
linux-can@vger•kernel.org, netdev <netdev@vger•kernel.org>,
linux-kernel <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH] can: mpc5xxx_can: check of_iomap return before use
Date: Mon, 23 Jul 2018 11:57:33 +0000 [thread overview]
Message-ID: <20180723115733.GA6529@osadl.at> (raw)
In-Reply-To: <4f81e688-3d5c-6174-5a76-f416ced63cf3@pengutronix.de>
On Mon, Jul 23, 2018 at 01:37:05PM +0200, Marc Kleine-Budde wrote:
> On 07/09/2018 09:28 PM, Fabio Estevam wrote:
> > On Mon, Jul 9, 2018 at 4:16 PM, Nicholas Mc Guire <hofrat@osadl•org> wrote:
> >> of_iompa() can return NULL so that return needs to be checked and NULL
> >
> > s/of_iompa/of_iomap/
> >
> >> treated as failure. While at it also take care of the missing
> >> of_node_put() in the error path.
> >>
> >> Signed-off-by: Nicholas Mc Guire <hofrat@osadl•org>
> >> Fixes: commit afa17a500a36 ("net/can: add driver for mscan family & mpc52xx_mscan")
> >> ---
> >>
> >> Problem was found by an experimental coccinelle script
> >>
> >> Patch was compiletested with: mpc5200_defconfig + CONFIG_CAN=y,
> >> CONFIG_CAN_MSCAN=y, CONFIG_CAN_MPC5XXX=y
> >> (with a number of sparse warnings not related to the proposed change)
> >>
> >> Patch is against 4.18-rc3 (localversion-next is next-20180706)
> >>
> >> drivers/net/can/mscan/mpc5xxx_can.c | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >>
> >> diff --git a/drivers/net/can/mscan/mpc5xxx_can.c b/drivers/net/can/mscan/mpc5xxx_can.c
> >> index c7427bd..2949a38 100644
> >> --- a/drivers/net/can/mscan/mpc5xxx_can.c
> >> +++ b/drivers/net/can/mscan/mpc5xxx_can.c
> >> @@ -86,6 +86,11 @@ static u32 mpc52xx_can_get_clock(struct platform_device *ofdev,
> >> return 0;
> >> }
> >> cdm = of_iomap(np_cdm, 0);
> >> + if (!cdm) {
> >> + of_node_put(np_cdm);
> >> + dev_err(&ofdev->dev, "can't map clock node!\n");
> >> + return 0;
> >
> > I think you should return an error code here. -ENOMEM maybe?
>
> Can you send an updated version?
>
The way I understand the code the return value will be used
as a frequency - the only valid error valeu thus is 0 here,
so I think the return 0 is correct.
thx!
hofrat
next prev parent reply other threads:[~2018-07-23 11:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 19:16 [PATCH] can: mpc5xxx_can: check of_iomap return before use Nicholas Mc Guire
2018-07-09 19:28 ` Fabio Estevam
2018-07-09 19:31 ` Nicholas Mc Guire
2018-07-09 19:35 ` Fabio Estevam
2018-07-23 11:37 ` Marc Kleine-Budde
2018-07-23 11:57 ` Nicholas Mc Guire [this message]
2018-07-23 12:27 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180723115733.GA6529@osadl.at \
--to=der.herr@hofr$(echo .)at \
--cc=davem@davemloft$(echo .)net \
--cc=festevam@gmail$(echo .)com \
--cc=hofrat@osadl$(echo .)org \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mkl@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=w.sang@pengutronix$(echo .)de \
--cc=wg@grandegger$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox