From: Leon Romanovsky <leon@kernel•org>
To: Jason Gunthorpe <jgg@ziepe•ca>
Cc: Doug Ledford <dledford@redhat•com>,
RDMA mailing list <linux-rdma@vger•kernel.org>,
Yishai Hadas <yishaih@mellanox•com>,
Saeed Mahameed <saeedm@mellanox•com>,
linux-netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH rdma-next v2 0/8] Support mlx5 flow steering with RAW data
Date: Tue, 24 Jul 2018 08:56:09 +0300 [thread overview]
Message-ID: <20180724055609.GG3189@mtr-leonro.mtl.com> (raw)
In-Reply-To: <20180724024236.GA16958@ziepe.ca>
[-- Attachment #1: Type: text/plain, Size: 2700 bytes --]
On Mon, Jul 23, 2018 at 08:42:36PM -0600, Jason Gunthorpe wrote:
> On Mon, Jul 23, 2018 at 03:25:04PM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@mellanox•com>
> >
> > Changelog:
> > v1->v2:
> > * Fix matcher to use the correct size.
> > * Rephrase commit log of the first patch.
> > v0->v1:
> > * Fixed ADD_UVERBS_ATTRIBUTES_SIMPLE macro to pass the real address.
> > ?* Replaced UA_ALLOC_AND_COPY to regular copy_from
> > * Added UVERBS_ATTR_NO_DATA new macro for cleaner code.
> > * Used ib_dev from uobj when it exists.
> > * ib_is_destroy_retryable was replaced by ib_destroy_usecnt
> >
> > >From Yishai:
> >
> > This series introduces vendor create and destroy flow methods on the
> > uverbs flow object by using the KABI infra-structure.
> >
> > It's done in a way that enables the driver to get its specific device
> > attributes in a raw data to match its underlay specification while still
> > using the generic ib_flow object for cleanup and code sharing.
> >
> > In addition, a specific mlx5 matcher object and its create/destroy
> > methods were introduced. This object matches the underlay flow steering
> > mask specification and is used as part of mlx5 create flow input data.
> >
> > This series supports IB_QP/TIR as its flow steering destination as
> > applicable today via the ib_create_flow API, however, it adds also an
> > option to work with DEVX object which its destination can be both TIR
> > and flow table.
> >
> > Few changes were done in the mlx5 core layer to support forward
> > compatible for the device specification raw data and to support flow
> > table when the DEVX destination is used.
> >
> > As part of this series the default IB destroy handler
> > (i.e. uverbs_destroy_def_handler()) was exposed from IB core to be
> > used by the drivers and existing code was refactored to use it.
> >
> > Thanks
> >
> > Yishai Hadas (8):
> > net/mlx5: Add forward compatible support for the FTE match data
> > net/mlx5: Add support for flow table destination number
> > IB/mlx5: Introduce flow steering matcher object
> > IB: Consider ib_flow creation by the KABI infrastructure
> > IB/mlx5: Introduce vendor create and destroy flow methods
> > IB/mlx5: Support adding flow steering rule by raw data
> > IB/mlx5: Add support for a flow table destination
> > IB/mlx5: Expose vendor flow trees
>
> This seems fine to me. Can you send the mlx5 shared branch for the
> first two patches?
I applied two first patches with Acked-by from Saeed to mlx5-next
664000b6bb43 net/mlx5: Add support for flow table destination number
2aada6c0c96e net/mlx5: Add forward compatible support for the FTE match data
Thanks
>
> Thanks,
> Jason
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2018-07-24 7:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 12:25 [PATCH rdma-next v2 0/8] Support mlx5 flow steering with RAW data Leon Romanovsky
2018-07-23 12:25 ` [PATCH mlx5-next v2 1/8] net/mlx5: Add forward compatible support for the FTE match data Leon Romanovsky
2018-07-23 21:05 ` Saeed Mahameed
2018-07-23 12:25 ` [PATCH mlx5-next v2 2/8] net/mlx5: Add support for flow table destination number Leon Romanovsky
2018-07-23 21:05 ` Saeed Mahameed
2018-07-23 12:25 ` [PATCH rdma-next v2 3/8] IB/mlx5: Introduce flow steering matcher object Leon Romanovsky
2018-07-23 12:25 ` [PATCH rdma-next v2 4/8] IB: Consider ib_flow creation by the KABI infrastructure Leon Romanovsky
2018-07-23 12:25 ` [PATCH rdma-next v2 5/8] IB/mlx5: Introduce vendor create and destroy flow methods Leon Romanovsky
2018-07-23 12:25 ` [PATCH rdma-next v2 6/8] IB/mlx5: Support adding flow steering rule by raw data Leon Romanovsky
2018-07-23 12:25 ` [PATCH rdma-next v2 7/8] IB/mlx5: Add support for a flow table destination Leon Romanovsky
2018-07-23 12:25 ` [PATCH rdma-next v2 8/8] IB/mlx5: Expose vendor flow trees Leon Romanovsky
2018-07-24 2:42 ` [PATCH rdma-next v2 0/8] Support mlx5 flow steering with RAW data Jason Gunthorpe
2018-07-24 5:56 ` Leon Romanovsky [this message]
2018-07-24 20:13 ` Jason Gunthorpe
2018-07-24 20:35 ` Jason Gunthorpe
2018-07-25 5:37 ` Leon Romanovsky
2018-07-25 14:35 ` Jason Gunthorpe
2018-07-26 4:35 ` Leon Romanovsky
2018-07-26 14:58 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724055609.GG3189@mtr-leonro.mtl.com \
--to=leon@kernel$(echo .)org \
--cc=dledford@redhat$(echo .)com \
--cc=jgg@ziepe$(echo .)ca \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=saeedm@mellanox$(echo .)com \
--cc=yishaih@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox