From: "liujunliang_ljl@163•com" <liujunliang_ljl@163•com>
To: "Jia-Ju Bai" <baijiaju1990@gmail•com>
Cc: linux-usb <linux-usb@vger•kernel.org>,
netdev <netdev@vger•kernel.org>,
linux-kernel <linux-kernel@vger•kernel.org>,
"Jia-Ju Bai" <baijiaju1990@gmail•com>
Subject: Re: [PATCH] net: usb: sr9700: Replace mdelay() with msleep() in sr9700_bind()
Date: Fri, 27 Jul 2018 17:04:48 +0800 [thread overview]
Message-ID: <201807271704468308230@163.com> (raw)
In-Reply-To: 20180727084104.29726-1-baijiaju1990@gmail.com
[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]
Dear Jia-Ju Bai :
OK.
the patch is ok.
liujunliang_ljl@163•com
From: Jia-Ju Bai
Date: 2018-07-27 16:41
To: liujunliang_ljl
CC: linux-usb; netdev; linux-kernel; Jia-Ju Bai
Subject: [PATCH] net: usb: sr9700: Replace mdelay() with msleep() in sr9700_bind()
sr9700_bind() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().
This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail•com>
---
drivers/net/usb/sr9700.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c
index 2d316c1b851b..6ac232e52bf7 100644
--- a/drivers/net/usb/sr9700.c
+++ b/drivers/net/usb/sr9700.c
@@ -358,7 +358,7 @@ static int sr9700_bind(struct usbnet *dev, struct usb_interface *intf)
/* power up and reset phy */
sr_write_reg(dev, SR_PRR, PRR_PHY_RST);
/* at least 10ms, here 20ms for safe */
- mdelay(20);
+ msleep(20);
sr_write_reg(dev, SR_PRR, 0);
/* at least 1ms, here 2ms for reading right register */
udelay(2 * 1000);
--
2.17.0
[-- Attachment #2: Type: text/html, Size: 3544 bytes --]
next prev parent reply other threads:[~2018-07-27 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 8:41 [PATCH] net: usb: sr9700: Replace mdelay() with msleep() in sr9700_bind() Jia-Ju Bai
2018-07-27 9:04 ` liujunliang_ljl [this message]
2018-07-27 21:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201807271704468308230@163.com \
--to=liujunliang_ljl@163$(echo .)com \
--cc=baijiaju1990@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox