From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro•org>
To: Andrew Lunn <andrew@lunn•ch>
Cc: grygorii.strashko@ti•com, davem@davemloft•net,
linux-omap@vger•kernel.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH net-next] net: ethernet: ti: cpsw: replace unnecessarily macroses on functions
Date: Fri, 27 Jul 2018 23:49:51 +0300 [thread overview]
Message-ID: <20180727204950.GD2619@khorivan> (raw)
In-Reply-To: <20180727203203.GB17441@lunn.ch>
On Fri, Jul 27, 2018 at 10:32:03PM +0200, Andrew Lunn wrote:
>> +static inline void cpsw_src_port_detect(struct cpsw_common *cpsw, int status,
>> + struct sk_buff *skb)
>
>Please don't use inline. Let the compiler decide.
>
> Andrew
Corrected in v2
--
Regards,
Ivan Khoronzhuk
prev parent reply other threads:[~2018-07-27 20:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 19:13 [PATCH net-next] net: ethernet: ti: cpsw: replace unnecessarily macroses on functions Ivan Khoronzhuk
2018-07-27 19:15 ` Grygorii Strashko
2018-07-27 19:21 ` Joe Perches
2018-07-27 19:36 ` Ivan Khoronzhuk
2018-07-27 19:52 ` Ivan Khoronzhuk
2018-07-27 20:04 ` Joe Perches
2018-07-27 20:23 ` Ivan Khoronzhuk
2018-07-27 20:29 ` Joe Perches
2018-07-27 20:32 ` Andrew Lunn
2018-07-27 20:49 ` Ivan Khoronzhuk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727204950.GD2619@khorivan \
--to=ivan.khoronzhuk@linaro$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=grygorii.strashko@ti$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox