Subject: Re: [PATCH v8 bpf-next 05/10] veth: Handle xdp_frames in xdp napi ring

From: Jesper Dangaard Brouer <[email-masked]>
Date: Fri, 3 Aug 2018 11:07:10 +0200

On Fri,  3 Aug 2018 16:58:13 +0900
Toshiaki Makita <[email-masked]> wrote:

> This is preparation for XDP TX and ndo_xdp_xmit.
> This allows napi handler to handle xdp_frames through xdp ring as well
> as sk_buff.
> 
> v8:
> - Don't use xdp_frame pointer address to calculate skb->head and
>   headroom.
> 
> v7:
> - Use xdp_scrub_frame() instead of memset().
> 
> v3:
> - Revert v2 change around rings and use a flag to differentiate skb and
>   xdp_frame, since bulk skb xmit makes little performance difference
>   for now.
> 
> v2:
> - Use another ring instead of using flag to differentiate skb and
>   xdp_frame. This approach makes bulk skb transmit possible in
>   veth_xmit later.
> - Clear xdp_frame feilds in skb->head.
> - Implement adjust_tail.
> 
> Signed-off-by: Toshiaki Makita <[email-masked]>
> Acked-by: John Fastabend <[email-masked]>

Acked-by: Jesper Dangaard Brouer <[email-masked]>

Thanks this looks much better.

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer