From: Ido Schimmel <idosch@mellanox•com>
To: netdev@vger•kernel.org, sfr@canb•auug.org.au
Cc: davem@davemloft•net, jiri@mellanox•com, petrm@mellanox•com,
nird@mellanox•com, mlxsw@mellanox•com
Subject: Re: [PATCH net 1/4] mlxsw: core_acl_flex_actions: Return error for conflicting actions
Date: Fri, 3 Aug 2018 16:03:54 +0300 [thread overview]
Message-ID: <20180803130354.GA16394@splinter.mtl.com> (raw)
In-Reply-To: <20180803125744.16200-2-idosch@mellanox.com>
+Stephen
On Fri, Aug 03, 2018 at 03:57:41PM +0300, Ido Schimmel wrote:
> From: Nir Dotan <nird@mellanox•com>
>
> Spectrum switch ACL action set is built in groups of three actions
> which may point to additional actions. A group holds a single record
> which can be set as goto record for pointing at a following group
> or can be set to mark the termination of the lookup. This is perfectly
> adequate for handling a series of actions to be executed on a packet.
> While the SW model allows configuration of conflicting actions
> where it is clear that some actions will never execute, the mlxsw
> driver must block such configurations as it creates a conflict
> over the single terminate/goto record value.
...
> Where it is clear that the last action will never execute, the
> mlxsw driver was issuing a warning instead of returning an error.
> Therefore replace that warning with an error for this specific
> case.
>
> Fixes: 4cda7d8d7098 ("mlxsw: core: Introduce flexible actions support")
> Signed-off-by: Nir Dotan <nird@mellanox•com>
> Reviewed-by: Jiri Pirko <jiri@mellanox•com>
> Signed-off-by: Ido Schimmel <idosch@mellanox•com>
> ---
> .../mellanox/mlxsw/core_acl_flex_actions.c | 42 +++++++++----------
Dave / Stephen, please note that this is going to conflict with recent
extack changes in net-next when you merge net into net-next.
Resolution is available here:
https://github.com/jpirko/linux_mlxsw/blob/combined_queue/drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c
Thanks and sorry about the conflict
next prev parent reply other threads:[~2018-08-03 15:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 12:57 [PATCH net 0/4] mlxsw: Fix ACL actions error condition handling Ido Schimmel
2018-08-03 12:57 ` [PATCH net 1/4] mlxsw: core_acl_flex_actions: Return error for conflicting actions Ido Schimmel
2018-08-03 13:03 ` Ido Schimmel [this message]
2018-08-03 12:57 ` [PATCH net 2/4] mlxsw: core_acl_flex_actions: Remove redundant resource destruction Ido Schimmel
2018-08-03 12:57 ` [PATCH net 3/4] mlxsw: core_acl_flex_actions: Remove redundant counter destruction Ido Schimmel
2018-08-03 12:57 ` [PATCH net 4/4] mlxsw: core_acl_flex_actions: Remove redundant mirror resource destruction Ido Schimmel
2018-08-03 19:35 ` [PATCH net 0/4] mlxsw: Fix ACL actions error condition handling David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180803130354.GA16394@splinter.mtl.com \
--to=idosch@mellanox$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jiri@mellanox$(echo .)com \
--cc=mlxsw@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nird@mellanox$(echo .)com \
--cc=petrm@mellanox$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox