From: Ben Pfaff <blp-LZ6Gd1LRuIk@public•gmane.org>
To: Stefano Brivio <sbrivio-H+wXaHxf7aLQT0dZR+AlfA@public•gmane.org>
Cc: dev-yBygre7rU0TnMu66kgdUjQ@public•gmane.org,
jpettit-pghWNbHTmq7QT0dZR+AlfA@public•gmane.org,
netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
Jiri Benc <jbenc-H+wXaHxf7aLQT0dZR+AlfA@public•gmane.org>
Subject: Re: [PATCH RFC net-next] openvswitch: Queue upcalls to userspace in per-port round-robin order
Date: Fri, 3 Aug 2018 17:54:52 -0700 [thread overview]
Message-ID: <20180804005452.GI29662@ovn.org> (raw)
In-Reply-To: <20180804024324.4d900b5e@epycfail>
On Sat, Aug 04, 2018 at 02:43:24AM +0200, Stefano Brivio wrote:
> On Fri, 3 Aug 2018 16:01:08 -0700
> Ben Pfaff <blp-LZ6Gd1LRuIk@public•gmane.org> wrote:
> > I would be very pleased if we could integrate a simple mechanism for
> > fairness, based for now on some simple criteria like the source port,
> > but thinking ahead to how we could later make it gracefully extensible
> > to consider more general and possibly customizable criteria.
>
> We could change the patch so that instead of just using the vport for
> round-robin queue insertion, we generalise that and use "buckets"
> instead of vports, and have a set of possible functions that are called
> instead of using port_no directly in ovs_dp_upcall_queue_roundrobin(),
> making this configurable via netlink, per datapath.
>
> We could implement selection based on source port or a hash on the
> source 5-tuple, and the relevant bits of
> ovs_dp_upcall_queue_roundrobin() would look like this:
[...]
> What do you think?
I'd support that. Thanks.
next prev parent reply other threads:[~2018-08-04 0:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 14:23 [PATCH RFC net-next] openvswitch: Queue upcalls to userspace in per-port round-robin order Matteo Croce
[not found] ` <20180704142342.21740-1-mcroce-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-10 18:31 ` Pravin Shelar
2018-07-16 16:54 ` Matteo Croce
2018-07-31 19:43 ` Matteo Croce
[not found] ` <CAGnkfhyxQSz=8OsgTsjR3NfZ2FPwv+FjPZNPEY5VHZRsEiQ68w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-07-31 22:06 ` Ben Pfaff
2018-08-03 16:52 ` Stefano Brivio
2018-08-03 23:01 ` Ben Pfaff
2018-08-04 0:43 ` Stefano Brivio
2018-08-04 0:54 ` Ben Pfaff [this message]
2018-08-10 14:11 ` William Tu
2018-08-14 15:25 ` Stefano Brivio
2018-07-31 23:12 ` Pravin Shelar
2018-08-07 13:31 ` Stefano Brivio
2018-08-07 13:39 ` Stefano Brivio
2018-08-15 7:19 ` Pravin Shelar
[not found] ` <CAOrHB_DaA-+J=jzNOdQiUYrA7RJi30HmRESjsmGs7_z1ffpVOA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-08-16 21:07 ` Stefano Brivio
2018-09-26 9:58 ` Stefano Brivio
2018-09-28 17:15 ` Pravin Shelar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180804005452.GI29662@ovn.org \
--to=blp-lz6gd1lruik@public$(echo .)gmane.org \
--cc=dev-yBygre7rU0TnMu66kgdUjQ@public$(echo .)gmane.org \
--cc=jbenc-H+wXaHxf7aLQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=jpettit-pghWNbHTmq7QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=sbrivio-H+wXaHxf7aLQT0dZR+AlfA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox