From: Andrew Lunn <andrew@lunn•ch>
To: "Marek Behún" <marek.behun@nic•cz>
Cc: linux-arm-kernel@lists•infradead.org, netdev@vger•kernel.org,
Gregory CLEMENT <gregory.clement@bootlin•com>,
Tomas Hlavacek <tomas.hlavacek@nic•cz>,
Russell King - ARM Linux <linux@armlinux•org.uk>
Subject: Re: [PATCH v1 6/7] net: mvneta: Don't use GRO on Armada 3720
Date: Wed, 8 Aug 2018 18:58:46 +0200 [thread overview]
Message-ID: <20180808165846.GK7275@lunn.ch> (raw)
In-Reply-To: <20180808152706.21727-7-marek.behun@nic.cz>
On Wed, Aug 08, 2018 at 05:27:05PM +0200, Marek Behún wrote:
> For some reason on Armada 3720 boards (EspressoBin and Turris Mox) the
> networking driver behaves weirdly when using napi_gro_receive.
>
> For example downloading a big file from a local network (low ping) is
> fast, but when downloading from a remote server (higher ping), the
> download speed is at first high but drops rapidly to almost nothing or
> absolutely nothing.
>
> This is fixed when using netif_receive_skb instead of napi_gro_receive.
Before doing this, we should really understand what is going on. It is
probably just a driver bug which needs fixing. And GRO should be good
for performance, so we do want to use it, if possible.
Andrew
next prev parent reply other threads:[~2018-08-08 19:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180808152706.21727-1-marek.behun@nic.cz>
2018-08-08 15:27 ` [PATCH v1 6/7] net: mvneta: Don't use GRO on Armada 3720 Marek Behún
2018-08-08 16:58 ` Andrew Lunn [this message]
2018-08-08 17:57 ` Dave Taht
2018-08-09 4:40 ` Jisheng Zhang
2018-08-09 11:27 ` Jisheng Zhang
2018-08-09 12:08 ` Jisheng Zhang
2018-08-21 10:07 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180808165846.GK7275@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=gregory.clement@bootlin$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=marek.behun@nic$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tomas.hlavacek@nic$(echo .)cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox