From: Greg KH <gregkh@linux-foundation•org>
To: maowenan <maowenan@huawei•com>
Cc: David Woodhouse <dwmw@amazon•co.uk>,
davem@davemloft•net, edumazet@google•com,
juha-matti.tilli@iki•fi, ycheng@google•com, soheil@google•com,
netdev@vger•kernel.org, eric.dumazet@gmail•com,
dwmw2@infradead•org, jdw@amazon•de
Subject: Re: [PATCH 4.9-stable] tcp: add tcp_ooo_try_coalesce() helper
Date: Thu, 9 Aug 2018 14:47:26 +0200 [thread overview]
Message-ID: <20180809124726.GA9500@kroah.com> (raw)
In-Reply-To: <20e03726-c053-67a3-505a-7110be0f5d34@huawei.com>
On Thu, Aug 09, 2018 at 08:37:13PM +0800, maowenan wrote:
>
>
> On 2018/8/7 21:22, Greg KH wrote:
> > On Sat, Aug 04, 2018 at 10:10:00AM +0100, David Woodhouse wrote:
> >> From: Eric Dumazet <edumazet@google•com>
> >>
> >> commit 58152ecbbcc6a0ce7fddd5bf5f6ee535834ece0c upstream.
> >>
> >> In case skb in out_or_order_queue is the result of
> >> multiple skbs coalescing, we would like to get a proper gso_segs
> >> counter tracking, so that future tcp_drop() can report an accurate
> >> number.
> >>
> >> I chose to not implement this tracking for skbs in receive queue,
> >> since they are not dropped, unless socket is disconnected.
> >>
> >> Signed-off-by: Eric Dumazet <edumazet@google•com>
> >> Acked-by: Soheil Hassas Yeganeh <soheil@google•com>
> >> Acked-by: Yuchung Cheng <ycheng@google•com>
> >> Signed-off-by: David S. Miller <davem@davemloft•net>
> >> Signed-off-by: David Woodhouse <dwmw@amazon•co.uk>
> >> ---
> >> net/ipv4/tcp_input.c | 23 +++++++++++++++++++++--
> >> 1 file changed, 21 insertions(+), 2 deletions(-)
> >
> > Now applied, thanks,
> >
> > greg k-h
> >
> > .
> >
>
> Hello,
>
> There are two patches in stable branch linux-4.4, but I have tested with below patches, and found that the cpu usage was very high.
> dc6ae4d tcp: detect malicious patterns in tcp_collapse_ofo_queue()
> 5fbec48 tcp: avoid collapses in tcp_prune_queue() if possible
>
> test results:
> with fix patch： 78.2% ksoftirqd
> no fix patch： 90% ksoftirqd
>
> there is %0 when no attack packets.
>
> so please help verify that fixed patches are enough in linux-stable 4.4.
>
I do not know, I am not a network developer. Please try to reproduce
the same thing on a newer kernel release and see if the result is the
same or not. If you can find a change that I missed, please let me know
and I will be glad to apply it.
thnaks,
greg k-h
next prev parent reply other threads:[~2018-08-09 15:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 16:28 [PATCH net 0/5] tcp: more robust ooo handling Eric Dumazet
2018-07-23 16:28 ` [PATCH net 1/5] tcp: free batches of packets in tcp_prune_ofo_queue() Eric Dumazet
2018-07-23 16:28 ` [PATCH net 2/5] tcp: avoid collapses in tcp_prune_queue() if possible Eric Dumazet
2018-07-23 16:28 ` [PATCH net 3/5] tcp: detect malicious patterns in tcp_collapse_ofo_queue() Eric Dumazet
2018-07-23 16:28 ` [PATCH net 4/5] tcp: call tcp_drop() from tcp_data_queue_ofo() Eric Dumazet
2018-07-23 16:28 ` [PATCH net 5/5] tcp: add tcp_ooo_try_coalesce() helper Eric Dumazet
2018-07-23 19:03 ` [PATCH net 0/5] tcp: more robust ooo handling David Miller
2018-08-03 10:55 ` David Woodhouse
2018-08-03 23:53 ` David Miller
2018-08-04 7:05 ` Greg KH
2018-08-04 9:04 ` David Woodhouse
2018-08-04 9:10 ` [PATCH 4.9-stable] tcp: add tcp_ooo_try_coalesce() helper David Woodhouse
2018-08-07 13:22 ` Greg KH
2018-08-09 12:37 ` maowenan
2018-08-09 12:47 ` Greg KH [this message]
2018-08-09 12:52 ` David Woodhouse
2018-08-10 2:02 ` maowenan
2018-08-10 6:26 ` maowenan
2018-08-10 10:10 ` maowenan
2018-08-10 1:56 ` maowenan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180809124726.GA9500@kroah.com \
--to=gregkh@linux-foundation$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dwmw2@infradead$(echo .)org \
--cc=dwmw@amazon$(echo .)co.uk \
--cc=edumazet@google$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=jdw@amazon$(echo .)de \
--cc=juha-matti.tilli@iki$(echo .)fi \
--cc=maowenan@huawei$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=soheil@google$(echo .)com \
--cc=ycheng@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox