From: "Gustavo A. R. Silva" <gustavo@embeddedor•com>
To: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel•com>,
linux-wimax@intel•com, "David S. Miller" <davem@davemloft•net>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor•com>
Subject: [PATCH net-next] wimax: usb-fw: mark expected switch fall-through
Date: Thu, 9 Aug 2018 10:39:44 -0500 [thread overview]
Message-ID: <20180809153944.GA16703@embeddedor.com> (raw)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that in this particular case, I placed the "fall through"
annotation at the bottom of the case, which is what GCC is expecting
to find.
Addresses-Coverity-ID: 1369529 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor•com>
---
drivers/net/wimax/i2400m/usb-fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wimax/i2400m/usb-fw.c b/drivers/net/wimax/i2400m/usb-fw.c
index 502c346..529ebca 100644
--- a/drivers/net/wimax/i2400m/usb-fw.c
+++ b/drivers/net/wimax/i2400m/usb-fw.c
@@ -130,12 +130,12 @@ ssize_t i2400mu_tx_bulk_out(struct i2400mu *i2400mu, void *buf, size_t buf_size)
dev_err(dev, "BM-CMD: too many stalls in "
"URB; resetting device\n");
usb_queue_reset_device(i2400mu->usb_iface);
- /* fallthrough */
} else {
usb_clear_halt(i2400mu->usb_dev, pipe);
msleep(10); /* give the device some time */
goto retry;
}
+ /* fall through */
case -EINVAL: /* while removing driver */
case -ENODEV: /* dev disconnect ... */
case -ENOENT: /* just ignore it */
--
2.7.4
next reply other threads:[~2018-08-09 15:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 15:39 Gustavo A. R. Silva [this message]
2018-08-11 18:30 ` [PATCH net-next] wimax: usb-fw: mark expected switch fall-through David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180809153944.GA16703@embeddedor.com \
--to=gustavo@embeddedor$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=inaky.perez-gonzalez@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wimax@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox