From: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
To: linux-kernel@vger•kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
stable@vger•kernel.org, Mark Salyzyn <salyzyn@android•com>,
Marcel Holtmann <marcel@holtmann•org>,
Johan Hedberg <johan.hedberg@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Kees Cook <keescook@chromium•org>,
Benjamin Tissoires <benjamin.tissoires@redhat•com>,
linux-bluetooth@vger•kernel.org, netdev@vger•kernel.org,
security@kernel•org, kernel-team@android•com
Subject: [PATCH 4.14 20/22] Bluetooth: hidp: buffer overflow in hidp_process_report
Date: Thu, 16 Aug 2018 20:45:21 +0200 [thread overview]
Message-ID: <20180816171625.311412216@linuxfoundation.org> (raw)
In-Reply-To: <20180816171622.831964729@linuxfoundation.org>
4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Mark Salyzyn <salyzyn@android•com>
commit 7992c18810e568b95c869b227137a2215702a805 upstream.
CVE-2018-9363
The buffer length is unsigned at all layers, but gets cast to int and
checked in hidp_process_report and can lead to a buffer overflow.
Switch len parameter to unsigned int to resolve issue.
This affects 3.18 and newer kernels.
Signed-off-by: Mark Salyzyn <salyzyn@android•com>
Fixes: a4b1b5877b514b276f0f31efe02388a9c2836728 ("HID: Bluetooth: hidp: make sure input buffers are big enough")
Cc: Marcel Holtmann <marcel@holtmann•org>
Cc: Johan Hedberg <johan.hedberg@gmail•com>
Cc: "David S. Miller" <davem@davemloft•net>
Cc: Kees Cook <keescook@chromium•org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat•com>
Cc: linux-bluetooth@vger•kernel.org
Cc: netdev@vger•kernel.org
Cc: linux-kernel@vger•kernel.org
Cc: security@kernel•org
Cc: kernel-team@android•com
Acked-by: Kees Cook <keescook@chromium•org>
Signed-off-by: Marcel Holtmann <marcel@holtmann•org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
---
net/bluetooth/hidp/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/net/bluetooth/hidp/core.c
+++ b/net/bluetooth/hidp/core.c
@@ -431,8 +431,8 @@ static void hidp_del_timer(struct hidp_s
del_timer(&session->timer);
}
-static void hidp_process_report(struct hidp_session *session,
- int type, const u8 *data, int len, int intr)
+static void hidp_process_report(struct hidp_session *session, int type,
+ const u8 *data, unsigned int len, int intr)
{
if (len > HID_MAX_BUFFER_SIZE)
len = HID_MAX_BUFFER_SIZE;
parent reply other threads:[~2018-08-16 18:45 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20180816171622.831964729@linuxfoundation.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180816171625.311412216@linuxfoundation.org \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=benjamin.tissoires@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=johan.hedberg@gmail$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=kernel-team@android$(echo .)com \
--cc=linux-bluetooth@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=marcel@holtmann$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=salyzyn@android$(echo .)com \
--cc=security@kernel$(echo .)org \
--cc=stable@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox