Subject: [PATCH 4.4 11/13] Bluetooth: hidp: buffer overflow in hidp_process_report

From: Greg Kroah-Hartman <[email-masked]>
Date: Thu, 16 Aug 2018 20:41:58 +0200

4.4-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Mark Salyzyn <[email-masked]>

commit 7992c18810e568b95c869b227137a2215702a805 upstream.

CVE-2018-9363

The buffer length is unsigned at all layers, but gets cast to int and
checked in hidp_process_report and can lead to a buffer overflow.
Switch len parameter to unsigned int to resolve issue.

This affects 3.18 and newer kernels.

Signed-off-by: Mark Salyzyn <[email-masked]>
Fixes: a4b1b5877b514b276f0f31efe02388a9c2836728 ("HID: Bluetooth: hidp: make sure input buffers are big enough")
Cc: Marcel Holtmann <[email-masked]>
Cc: Johan Hedberg <[email-masked]>
Cc: "David S. Miller" <[email-masked]>
Cc: Kees Cook <[email-masked]>
Cc: Benjamin Tissoires <[email-masked]>
Cc: [email-masked]
Cc: [email-masked]
Cc: [email-masked]
Cc: [email-masked]
Cc: [email-masked]
Acked-by: Kees Cook <[email-masked]>
Signed-off-by: Marcel Holtmann <[email-masked]>
Signed-off-by: Greg Kroah-Hartman <[email-masked]>

---
 net/bluetooth/hidp/core.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/net/bluetooth/hidp/core.c
+++ b/net/bluetooth/hidp/core.c
@@ -431,8 +431,8 @@ static void hidp_del_timer(struct hidp_s
 		del_timer(&session->timer);
 }
 
-static void hidp_process_report(struct hidp_session *session,
-				int type, const u8 *data, int len, int intr)
+static void hidp_process_report(struct hidp_session *session, int type,
+				const u8 *data, unsigned int len, int intr)
 {
 	if (len > HID_MAX_BUFFER_SIZE)
 		len = HID_MAX_BUFFER_SIZE;