From: Andrew Lunn <andrew@lunn•ch>
To: Jiecheng Wu <jasonwood2031@gmail•com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH] fm10k_main.c: fix missing return value check of alloc_skb()
Date: Sat, 18 Aug 2018 04:14:14 +0200 [thread overview]
Message-ID: <20180818021414.GD26866@lunn.ch> (raw)
In-Reply-To: <20180818020058.14652-1-jasonwood2031@gmail.com>
On Sat, Aug 18, 2018 at 10:00:58AM +0800, Jiecheng Wu wrote:
> Function fm10k_init_module() defined in drivers/net/ethernet/intel/fm10k/fm10k_main.c calls alloc_workqueue() to allocate memory for struct workqueue_struct which is dereferenced immediately. As alloc_workqueue() may return NULL on failure, this code piece may cause NULL pointer dereference bug.
Hi Jiecheng
Please wrap your commit message to around 80 character wide.
You also need to add a Signed-off-by to your patch. Please see
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
scripts/checkpatch.pl will help you get these things rights.
Andrew
next prev parent reply other threads:[~2018-08-18 5:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-18 2:00 [PATCH] fm10k_main.c: fix missing return value check of alloc_skb() Jiecheng Wu
2018-08-18 2:14 ` Andrew Lunn [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-18 2:27 Jiecheng Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180818021414.GD26866@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=jasonwood2031@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox