From: Craig McGeachie <slapdau@gmail•com>
To: "David S. Miller" <davem@davemloft•net>, netdev@vger•kernel.org
Cc: Craig McGeachie <slapdau@gmail•com>,
Craig McGeachie <slapdau@yahoo•com.au>
Subject: [RFC 0/1] Appletalk AARP probe broken by receipt of own broadcasts.
Date: Sun, 19 Aug 2018 13:07:38 +1200 [thread overview]
Message-ID: <20180819010739.26975-1-slapdau@gmail.com> (raw)
I'm hoping I can find someone able and willing to test this patch. That
requires someone still using netatalk 2.2.x with DDP, or some other DDP
userspace application. This feels like a longshot.
When netatalk 2.2.x starts up with DDP and sets the Appletalk node
address, the kernel AARP code sends a probe packet for the address. It
then receives its own probe packet and interprets that as some other
node also trying to claim the address. It increments the address, tries
again, and fails again ad nausium. Eventually the kernel module gives up
and returns to netatalk which terminates with an error that it cannot
get a node address.
Well, most of the time. There seems to be some sort of race condition
where occasionally a self collision won't happen. Restart netatalk
enough times and it will probably work.
The device Ethernet MAC address is copied into the AARP packet, so the
fix is to disregard all received packets that have a sender address that
matches the device hardware address. This is more than just probe
packets, but there is no legitimate situation where an Appletalk node
sends AARP packets to itself.
Craig McGeachie (1):
appletalk: ignore aarp probe broadcasts that loopback.
net/appletalk/aarp.c | 4 ++++
1 file changed, 4 insertions(+)
--
2.17.1
next reply other threads:[~2018-08-19 4:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-19 1:07 Craig McGeachie [this message]
2018-08-19 1:07 ` [RFC 1/1] appletalk: ignore aarp probe broadcasts that loopback Craig McGeachie
2018-08-19 1:32 ` [RFC 0/1] Appletalk AARP probe broken by receipt of own broadcasts Andrew Lunn
2018-08-19 2:09 ` Craig McGeachie
2018-08-19 14:41 ` Andrew Lunn
2018-08-20 8:48 ` Craig McGeachie
2018-08-20 13:28 ` Andrew Lunn
2018-08-21 6:07 ` Craig McGeachie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180819010739.26975-1-slapdau@gmail.com \
--to=slapdau@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=slapdau@yahoo$(echo .)com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox