public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Ganesh Goudar <ganeshgr@chelsio•com>
To: Al Viro <viro@ZenIV•linux.org.uk>
Cc: Rahul Lakkireddy <rahul.lakkireddy@chelsio•com>,
	David Miller <davem@davemloft•net>,
	"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [endianness bug] cxgb4: mk_act_open_req() buggers ->{local,peer}_ip on big-endian hosts
Date: Wed, 22 Aug 2018 15:59:04 +0530	[thread overview]
Message-ID: <20180822102858.GA8912@chelsio.com> (raw)
In-Reply-To: <20180817194410.GH6515@ZenIV.linux.org.uk>

Hi Al,

All the issues you have mentioned make sense to me, I will fix them
and try to have them tested on big endian machine.
I got all the patches from net-endian.chelsio they all look good,
But I am yet to go through
(struct cxgb4_next_header .match_val/.match_mask/mask should be net-endian).

regarding "le64_to_cpu(*src)", I think we have not tested our vf driver on
a big endian machine. will address this as well.

Thanks
Ganesh

next prev parent reply	other threads:[~2018-08-22 13:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-05 17:22 [endianness bug] cxgb4: mk_act_open_req() buggers ->{local,peer}_ip on big-endian hosts Al Viro
2018-08-06 12:15 ` Rahul Lakkireddy
2018-08-14 21:25   ` Al Viro
2018-08-17 13:05     ` Ganesh Goudar
2018-08-17 15:43       ` Al Viro
2018-08-17 16:34         ` David Miller
2018-08-17 18:09         ` Al Viro
2018-08-17 18:58           ` Al Viro
2018-08-17 18:59             ` Al Viro
2018-08-17 19:44               ` Al Viro
2018-08-22 10:29                 ` Ganesh Goudar [this message]
2018-08-07 19:35 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180822102858.GA8912@chelsio.com \
    --to=ganeshgr@chelsio$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=rahul.lakkireddy@chelsio$(echo .)com \
    --cc=viro@ZenIV$(echo .)linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox