public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Luca Boccassi <bluca@debian•org>
To: netdev@vger•kernel.org
Cc: stephen@networkplumber•org, stefan.bader@canonical•com
Subject: [PATCH iproute2 2/3] testsuite: let make compile build the netlink helper
Date: Wed, 22 Aug 2018 19:09:02 +0100	[thread overview]
Message-ID: <20180822180903.26443-2-bluca@debian.org> (raw)
In-Reply-To: <20180822180903.26443-1-bluca@debian.org>

The generate_nlmsg binary is required but make -C testsuite compile
does not build it. Add the necessary includes and C*FLAGS to the tools
Makefile and have the compile target build it.

Signed-off-by: Luca Boccassi <bluca@debian•org>
---
 testsuite/Makefile       | 1 +
 testsuite/tools/Makefile | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/testsuite/Makefile b/testsuite/Makefile
index 2acd0427..5e269877 100644
--- a/testsuite/Makefile
+++ b/testsuite/Makefile
@@ -32,6 +32,7 @@ configure:
 
 compile: configure
 	echo "Entering iproute2" && cd iproute2 && $(MAKE) && cd ..;
+	$(MAKE) -C tools
 
 listtests:
 	@for t in $(TESTS); do \
diff --git a/testsuite/tools/Makefile b/testsuite/tools/Makefile
index f0ce4ee2..c936af71 100644
--- a/testsuite/tools/Makefile
+++ b/testsuite/tools/Makefile
@@ -1,6 +1,8 @@
 # SPDX-License-Identifier: GPL-2.0
+include ../../config.mk
+
 generate_nlmsg: generate_nlmsg.c ../../lib/libnetlink.c
-	$(CC) -o $@ $^
+	$(CC) $(CPPFLAGS) $(CFLAGS) $(LDLIBS) $(EXTRA_CFLAGS) -I../../include -include../../include/uapi/linux/netlink.h -o $@ $^
 
 clean:
 	rm -f generate_nlmsg
-- 
2.18.0

  reply	other threads:[~2018-08-22 21:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-22 18:09 [PATCH iproute2 1/3] testsuite: remove all temp files and implement make clean Luca Boccassi
2018-08-22 18:09 ` Luca Boccassi [this message]
2018-08-22 18:09 ` [PATCH iproute2 3/3] testsuite: run dmesg with sudo Luca Boccassi
2018-08-23  7:07 ` [PATCH iproute2 1/3] testsuite: remove all temp files and implement make clean Stefan Bader
2018-08-23  8:34   ` Luca Boccassi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180822180903.26443-2-bluca@debian.org \
    --to=bluca@debian$(echo .)org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=stefan.bader@canonical$(echo .)com \
    --cc=stephen@networkplumber$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox