Subject: Re: [PATCH net-next 09/12] net: ethernet: Add helper for MACs which support pause

From: Andrew Lunn <[email-masked]>
Date: Mon, 3 Sep 2018 21:54:10 +0200

On Mon, Sep 03, 2018 at 10:39:04AM -0700, Florian Fainelli wrote:
> 
> 
> On 9/2/2018 10:06 AM, Andrew Lunn wrote:
> >Rather than have the MAC drivers manipulate phydev members, add a
> >helper function for MACs supporting Pause, but not Asym Pause.
> >
> >Signed-off-by: Andrew Lunn <[email-masked]>
> 
> Reviewed-by: Florian Fainelli <[email-masked]>
> 
> I wonder if this would be better named phy_support_sym_pause() as opposed to
> asym_pause()?

Hi Florian

Maybe, bit it is then very similar to asym. I wounder if there is some
other word we can use for the symmetrical case?

      Andrew