From: Andrew Lunn <andrew@lunn•ch>
To: Igor Russkikh <igor.russkikh@aquantia•com>
Cc: "David S . Miller" <davem@davemloft•net>,
netdev@vger•kernel.org, Yana Esina <yana.esina@aquantia•com>,
Nikita Danilov <nikita.danilov@aquantia•com>
Subject: Re: [PATCH net-next v2 3/7] net: aquantia: implement WOL support
Date: Thu, 6 Sep 2018 15:34:01 +0200 [thread overview]
Message-ID: <20180906133401.GB7376@lunn.ch> (raw)
In-Reply-To: <66632a61b9d43ffe804de8abf3a09ec825ff2754.1536233536.git.igor.russkikh@aquantia.com>
On Thu, Sep 06, 2018 at 04:05:58PM +0300, Igor Russkikh wrote:
> From: Yana Esina <yana.esina@aquantia•com>
>
> Add WOL support. Currently only magic packet
> (ethtool -s <ethX> wol g) feature is implemented.
>
> Remove hw_set_power and move that to FW_OPS set_power:
> because WOL configuration behaves differently on 1x and 2x
> firmwares
Hi Igor, Yana
It looks like the set_power refactor could of been a patch of its own.
Then add the WOL support as a second patch.
In the future, try to make a patch do one thing, and only one
thing. It makes them easier to review.
Andrew
next prev parent reply other threads:[~2018-09-06 18:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 13:05 [PATCH net-next v2 0/7] net: aquantia: implement WOL and EEE support Igor Russkikh
2018-09-06 13:05 ` [PATCH net-next v2 1/7] net: aquantia: fix hw_atl_utils_fw_upload_dwords Igor Russkikh
2018-09-06 13:05 ` [PATCH net-next v2 2/7] net: aquantia: definitions for WOL Igor Russkikh
2018-09-06 13:23 ` Andrew Lunn
2018-09-06 13:05 ` [PATCH net-next v2 3/7] net: aquantia: implement WOL support Igor Russkikh
2018-09-06 13:34 ` Andrew Lunn [this message]
2018-09-06 13:44 ` Andrew Lunn
2018-09-06 13:05 ` [PATCH net-next v2 4/7] net: aquantia: implement EEE support Igor Russkikh
2018-09-06 13:06 ` [PATCH net-next v2 5/7] net: aquantia: whitespace changes Igor Russkikh
2018-09-06 13:42 ` Andrew Lunn
2018-09-06 13:06 ` [PATCH net-next v2 6/7] net: aquantia: renaming for better visibility Igor Russkikh
2018-09-06 13:44 ` Andrew Lunn
2018-09-06 13:06 ` [PATCH net-next v2 7/7] net: aquantia: bump driver version Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180906133401.GB7376@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=igor.russkikh@aquantia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikita.danilov@aquantia$(echo .)com \
--cc=yana.esina@aquantia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox