From: Phil Sutter <phil@nwl•cc>
To: Hangbin Liu <liuhangbin@gmail•com>
Cc: netdev@vger•kernel.org,
Stephen Hemminger <stephen@networkplumber•org>,
David Ahern <dsahern@gmail•com>
Subject: Re: [PATCHv2 iproute2] bridge/mdb: fix missing new line when show bridge mdb
Date: Tue, 11 Sep 2018 13:01:57 +0200 [thread overview]
Message-ID: <20180911110157.GF2630@orbyte.nwl.cc> (raw)
In-Reply-To: <1536629195-12540-1-git-send-email-liuhangbin@gmail.com>
Hi Hangbin,
On Tue, Sep 11, 2018 at 09:26:35AM +0800, Hangbin Liu wrote:
[...]
> + if (!is_json_context() && !show_stats)
> + print_string(PRINT_FP, NULL, "\n", NULL);
There is no need to check for !is_json_context() here. You give a type
of PRINT_FP which won't lead to output if JSON is active. For reference,
check print_color_string() in lib/json_print.c and _IS_JSON_CONTEXT
macro.
Cheers, Phil
next prev parent reply other threads:[~2018-09-11 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 3:33 [PATCH iproute2] bridge/mdb: fix missing new line when show bridge mdb Hangbin Liu
2018-09-06 13:00 ` Stephen Hemminger
2018-09-07 0:14 ` Hangbin Liu
2018-09-11 1:26 ` [PATCHv2 " Hangbin Liu
2018-09-11 11:01 ` Phil Sutter [this message]
2018-09-11 15:30 ` Stephen Hemminger
2018-09-11 14:04 ` [PATCHv3 " Hangbin Liu
2018-09-11 15:31 ` Stephen Hemminger
2018-09-12 1:39 ` [PATCHv4 " Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911110157.GF2630@orbyte.nwl.cc \
--to=phil@nwl$(echo .)cc \
--cc=dsahern@gmail$(echo .)com \
--cc=liuhangbin@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox