From: Guillaume Nault <g.nault@alphalink•fr>
To: netdev@vger•kernel.org
Cc: Alexander Potapenko <glider@google•com>,
Michal Ostrowski <mostrows@earthlink•net>,
Eric Dumazet <eric.dumazet@gmail•com>
Subject: Re: [PATCH net] pppoe: fix reception of frames with no mac header
Date: Fri, 14 Sep 2018 16:35:00 +0200 [thread overview]
Message-ID: <20180914143459.GC1507@alphalink.fr> (raw)
In-Reply-To: <274ac54fa02052104201d4738a6326a637e87a83.1536935190.git.g.nault@alphalink.fr>
On Fri, Sep 14, 2018 at 04:28:05PM +0200, Guillaume Nault wrote:
> pppoe_rcv() needs to look back at the Ethernet header in order to
> lookup the PPPoE session. Therefore we need to ensure that the mac
> header is big enough to contain an Ethernet header. Otherwise
> eth_hdr(skb)->h_source might access invalid data.
>
Forgot to Cc Alexander :/
Sorry...
BTW, thanks for your first analysis.
next prev parent reply other threads:[~2018-09-14 19:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 14:28 [PATCH net] pppoe: fix reception of frames with no mac header Guillaume Nault
2018-09-14 14:35 ` Guillaume Nault [this message]
2018-09-14 16:21 ` Alexander Potapenko
2018-09-17 14:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914143459.GC1507@alphalink.fr \
--to=g.nault@alphalink$(echo .)fr \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=glider@google$(echo .)com \
--cc=mostrows@earthlink$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox