From: Andrew Lunn <andrew@lunn•ch>
To: Quentin Schulz <quentin.schulz@bootlin•com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin•com>,
ralf@linux-mips•org, paul.burton@mips•com, jhogan@kernel•org,
robh+dt@kernel•org, mark.rutland@arm•com, davem@davemloft•net,
f.fainelli@gmail•com, allan.nielsen@microchip•com,
linux-mips@linux-mips•org, devicetree@vger•kernel.org,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
thomas.petazzoni@bootlin•com, antoine.tenart@bootlin•com
Subject: Re: [PATCH 5/7] MIPS: mscc: ocelot: add GPIO4 pinmuxing DT node
Date: Fri, 14 Sep 2018 19:02:21 +0200 [thread overview]
Message-ID: <20180914170221.GB3811@lunn.ch> (raw)
In-Reply-To: <20180914162638.fgzzjin2bzgx74de@qschulz>
On Fri, Sep 14, 2018 at 06:26:38PM +0200, Quentin Schulz wrote:
> Hi Alexandre,
>
> On Fri, Sep 14, 2018 at 04:54:46PM +0200, Alexandre Belloni wrote:
> > Hi,
> >
> > On 14/09/2018 11:44:26+0200, Quentin Schulz wrote:
> > > In order to use GPIO4 as a GPIO, we need to mux it in this mode so let's
> > > declare a new pinctrl DT node for it.
> > >
> > > Signed-off-by: Quentin Schulz <quentin.schulz@bootlin•com>
> > > ---
> > > arch/mips/boot/dts/mscc/ocelot.dtsi | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/arch/mips/boot/dts/mscc/ocelot.dtsi b/arch/mips/boot/dts/mscc/ocelot.dtsi
> > > index 8ce317c..b5c4c74 100644
> > > --- a/arch/mips/boot/dts/mscc/ocelot.dtsi
> > > +++ b/arch/mips/boot/dts/mscc/ocelot.dtsi
> > > @@ -182,6 +182,11 @@
> > > interrupts = <13>;
> > > #interrupt-cells = <2>;
> > >
> > > + gpio4: gpio4 {
> > > + pins = "GPIO_4";
> > > + function = "gpio";
> > > + };
> > > +
> >
> > For a GPIO, I would do that in the board dts because it is not used
> > directly in the dtsi.
> >
>
> And the day we've two boards using this pinctrl we move it to a dtsi. Is
> that the plan?
Hi Quentin
gpio4 appears to be pretty arbitrary. Could a different design use a
different gpio? It me, this seems like a board property.
Andrew
next prev parent reply other threads:[~2018-09-14 17:02 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 9:44 [PATCH net-next 0/7] add support for VSC8584 and VSC8574 Microsemi quad-port PHYs Quentin Schulz
2018-09-14 9:44 ` [PATCH net-next 1/7] dt-bindings: net: vsc8531: add two additional LED modes for VSC8584 Quentin Schulz
2018-09-14 13:11 ` Andrew Lunn
2018-09-15 21:34 ` Florian Fainelli
2018-09-14 9:44 ` [PATCH net-next 2/7] net: phy: mscc: add support for VSC8584 PHY Quentin Schulz
2018-09-14 13:18 ` Andrew Lunn
2018-09-14 13:29 ` Quentin Schulz
2018-09-14 16:28 ` Quentin Schulz
2018-09-14 16:58 ` Andrew Lunn
2018-10-01 9:16 ` Quentin Schulz
2018-09-14 17:27 ` Andrew Lunn
2018-10-01 9:15 ` Quentin Schulz
2018-09-14 9:44 ` [PATCH net-next 3/7] net: phy: mscc: split config_init in two functions for VSC8584 Quentin Schulz
2018-09-14 17:57 ` Florian Fainelli
2018-10-01 9:07 ` Quentin Schulz
2018-09-14 9:44 ` [PATCH net-next 4/7] net: phy: mscc: add support for VSC8574 PHY Quentin Schulz
2018-09-14 20:26 ` Florian Fainelli
2018-10-04 9:45 ` Quentin Schulz
2018-10-04 12:53 ` Quentin Schulz
2018-09-14 9:44 ` [PATCH 5/7] MIPS: mscc: ocelot: add GPIO4 pinmuxing DT node Quentin Schulz
2018-09-14 14:54 ` Alexandre Belloni
2018-09-14 16:26 ` Quentin Schulz
2018-09-14 17:02 ` Andrew Lunn [this message]
2018-10-01 9:01 ` Quentin Schulz
2018-09-14 18:02 ` Alexandre Belloni
2018-10-01 9:02 ` Quentin Schulz
2018-09-14 9:44 ` [PATCH 6/7] MIPS: mscc: add DT for Ocelot PCB120 Quentin Schulz
2018-09-14 14:58 ` Alexandre Belloni
2018-09-14 9:44 ` [PATCH 7/7] MIPS: mscc: add PCB120 to the ocelot fitImage Quentin Schulz
2018-09-14 15:00 ` Alexandre Belloni
2018-09-20 21:38 ` [PATCH net-next 0/7] add support for VSC8584 and VSC8574 Microsemi quad-port PHYs Linus Walleij
2018-10-11 6:18 ` Allan W. Nielsen
2018-10-11 7:55 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914170221.GB3811@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=allan.nielsen@microchip$(echo .)com \
--cc=antoine.tenart@bootlin$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=f.fainelli@gmail$(echo .)com \
--cc=jhogan@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=mark.rutland@arm$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paul.burton@mips$(echo .)com \
--cc=quentin.schulz@bootlin$(echo .)com \
--cc=ralf@linux-mips$(echo .)org \
--cc=robh+dt@kernel$(echo .)org \
--cc=thomas.petazzoni@bootlin$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox