From: Lance Roy <ldr709@gmail•com>
To: linux-kernel@vger•kernel.org
Cc: "Paul E. McKenney" <paulmck@linux•ibm.com>,
Lance Roy <ldr709@gmail•com>,
Jeff Kirsher <jeffrey.t.kirsher@intel•com>,
"David S. Miller" <davem@davemloft•net>,
intel-wired-lan@lists•osuosl.org, netdev@vger•kernel.org
Subject: [PATCH 05/16] igbvf: Replace spin_is_locked() with lockdep
Date: Tue, 2 Oct 2018 22:38:51 -0700 [thread overview]
Message-ID: <20181003053902.6910-6-ldr709@gmail.com> (raw)
In-Reply-To: <20181003053902.6910-1-ldr709@gmail.com>
lockdep_assert_held() is better suited to checking locking requirements,
since it won't get confused when someone else holds the lock. This is
also a step towards possibly removing spin_is_locked().
Signed-off-by: Lance Roy <ldr709@gmail•com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel•com>
Cc: "David S. Miller" <davem@davemloft•net>
Cc: intel-wired-lan@lists•osuosl.org
Cc: <netdev@vger•kernel.org>
---
drivers/net/ethernet/intel/igbvf/mbx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igbvf/mbx.c b/drivers/net/ethernet/intel/igbvf/mbx.c
index 163e5838f7c2..a3cd7ac48d4b 100644
--- a/drivers/net/ethernet/intel/igbvf/mbx.c
+++ b/drivers/net/ethernet/intel/igbvf/mbx.c
@@ -241,7 +241,7 @@ static s32 e1000_write_mbx_vf(struct e1000_hw *hw, u32 *msg, u16 size)
s32 err;
u16 i;
- WARN_ON_ONCE(!spin_is_locked(&hw->mbx_lock));
+ lockdep_assert_held(&hw->mbx_lock);
/* lock the mailbox to prevent pf/vf race condition */
err = e1000_obtain_mbx_lock_vf(hw);
@@ -279,7 +279,7 @@ static s32 e1000_read_mbx_vf(struct e1000_hw *hw, u32 *msg, u16 size)
s32 err;
u16 i;
- WARN_ON_ONCE(!spin_is_locked(&hw->mbx_lock));
+ lockdep_assert_held(&hw->mbx_lock);
/* lock the mailbox to prevent pf/vf race condition */
err = e1000_obtain_mbx_lock_vf(hw);
--
2.19.0
next prev parent reply other threads:[~2018-10-03 12:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181003053902.6910-1-ldr709@gmail.com>
2018-10-03 5:38 ` [PATCH 04/16] i40e: Replace spin_is_locked() with lockdep Lance Roy
2018-10-04 18:56 ` [Intel-wired-lan] " Bowers, AndrewX
2018-10-03 5:38 ` Lance Roy [this message]
2018-10-13 0:11 ` [PATCH 05/16] igbvf: " Brown, Aaron F
2018-10-03 5:38 ` [PATCH 06/16] sfc: " Lance Roy
2018-10-03 5:38 ` [PATCH 07/16] smsc: " Lance Roy
2018-10-03 5:38 ` [PATCH 08/16] wireless: " Lance Roy
2018-10-03 9:06 ` Kalle Valo
2018-10-04 6:57 ` Lance Roy
2018-10-04 10:05 ` Kalle Valo
2018-10-05 8:35 ` [PATCH 08/16] zd1211rw: " Kalle Valo
2018-10-03 5:39 ` [PATCH 14/16] netfilter: " Lance Roy
2018-10-03 8:29 ` Jozsef Kadlecsik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181003053902.6910-6-ldr709@gmail.com \
--to=ldr709@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paulmck@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox