From: Andrew Lunn <andrew@lunn•ch>
To: David Ahern <dsahern@kernel•org>
Cc: netdev@vger•kernel.org, davem@davemloft•net,
David Ahern <dsahern@gmail•com>
Subject: Re: [PATCH net-next 2/9] net/ipv4: Plumb support for filtering route dumps
Date: Thu, 11 Oct 2018 17:56:30 +0200 [thread overview]
Message-ID: <20181011155630.GG5708@lunn.ch> (raw)
In-Reply-To: <20181011150627.4010-3-dsahern@kernel.org>
> @@ -866,10 +866,13 @@ static int inet_dump_fib(struct sk_buff *skb, struct netlink_callback *cb)
> hlist_for_each_entry_rcu(tb, head, tb_hlist) {
> if (e < s_e)
> goto next;
> + if (filter.table_id && filter.table_id != tb->tb_id)
> + goto next;
> +
Hi David
Should there be a test here that filter->filter_set is set, before
looking at filter.table_id.
> if (dumped)
> memset(&cb->args[2], 0, sizeof(cb->args) -
> 2 * sizeof(cb->args[0]));
> - err = fib_table_dump(tb, skb, cb);
> + err = fib_table_dump(tb, skb, cb, &filter);
> if (err < 0) {
> if (likely(skb->len))
> goto out;
> diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c
> index 5bc0c89e81e4..237c9f72b265 100644
> --- a/net/ipv4/fib_trie.c
> +++ b/net/ipv4/fib_trie.c
> @@ -2003,12 +2003,17 @@ void fib_free_table(struct fib_table *tb)
> }
>
> static int fn_trie_dump_leaf(struct key_vector *l, struct fib_table *tb,
> - struct sk_buff *skb, struct netlink_callback *cb)
> + struct sk_buff *skb, struct netlink_callback *cb,
> + struct fib_dump_filter *filter)
> {
> + unsigned int flags = NLM_F_MULTI;
> __be32 xkey = htonl(l->key);
> struct fib_alias *fa;
> int i, s_i;
>
> + if (filter->filter_set)
> + flags |= NLM_F_DUMP_FILTERED;
With the above code, it seems like table_id could be filtered without
setting this flag to indicate some filters have been applied?
Andrew
next prev parent reply other threads:[~2018-10-11 23:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 15:06 [PATCH net-next 0/9] net: Kernel side filtering for route dumps David Ahern
2018-10-11 15:06 ` [PATCH net-next 1/9] net: Add struct for fib dump filter David Ahern
2018-10-11 15:06 ` [PATCH net-next 2/9] net/ipv4: Plumb support for filtering route dumps David Ahern
2018-10-11 15:56 ` Andrew Lunn [this message]
2018-10-11 16:44 ` David Ahern
2018-10-11 18:30 ` Andrew Lunn
2018-10-11 15:06 ` [PATCH net-next 3/9] net/ipv6: " David Ahern
2018-10-11 15:06 ` [PATCH net-next 4/9] net/mpls: " David Ahern
2018-10-11 15:06 ` [PATCH net-next 5/9] net: Plumb support for filtering ipv4 and ipv6 multicast " David Ahern
2018-10-11 15:06 ` [PATCH net-next 6/9] net: Enable kernel side filtering of " David Ahern
2018-10-11 15:06 ` [PATCH net-next 7/9] net/mpls: Handle " David Ahern
2018-10-11 15:06 ` [PATCH net-next 8/9] net/ipv6: Bail early if user only wants cloned entries David Ahern
2018-10-11 15:06 ` [PATCH net-next 9/9] net/ipv4: Bail early if user only wants prefix entries David Ahern
2018-10-11 15:26 ` [PATCH net-next 0/9] net: Kernel side filtering for route dumps Stephen Hemminger
2018-10-11 15:32 ` David Ahern
2018-10-11 16:10 ` Sowmini Varadhan
2018-10-11 16:13 ` David Ahern
2018-10-11 15:46 ` Sowmini Varadhan
2018-10-11 16:07 ` Jamal Hadi Salim
2018-10-11 16:16 ` David Ahern
2018-10-11 16:33 ` Roopa Prabhu
2018-10-11 16:37 ` Sowmini Varadhan
2018-10-11 16:46 ` Jamal Hadi Salim
2018-10-11 17:04 ` David Ahern
2018-10-11 18:05 ` Jamal Hadi Salim
2018-10-11 18:44 ` David Ahern
2018-10-11 19:28 ` David Miller
2018-10-11 19:32 ` Sowmini Varadhan
2018-10-11 19:43 ` David Miller
2018-10-11 19:54 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011155630.GG5708@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@gmail$(echo .)com \
--cc=dsahern@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox