From: Omar Sandoval <osandov@osandov•com>
To: Pablo Neira Ayuso <pablo@netfilter•org>,
Jozsef Kadlecsik <kadlec@blackhole•kfki.hu>,
Florian Westphal <fw@strlen•de>
Cc: "David S. Miller" <davem@davemloft•net>,
netfilter-devel@vger•kernel.org, coreteam@netfilter•org,
netdev@vger•kernel.org, kernel-team@fb•com
Subject: Re: [PATCH] netfilter: x_tables: fix missing unlock if table init fails
Date: Fri, 12 Oct 2018 16:35:17 -0700 [thread overview]
Message-ID: <20181012233517.GA21784@vader> (raw)
In-Reply-To: <32ddddccb89d8be6a73cd2de2fb20283b2ef6a94.1539385788.git.osandov@fb.com>
On Fri, Oct 12, 2018 at 04:16:53PM -0700, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb•com>
>
> Commit 7dde07e9c536 ("netfilter: x_tables: unlock on error in
> xt_find_table_lock()") fixed one missing unlock in xt_find_table_lock(),
> but we're also missing one if t->table_init() fails.
>
> Fixes: b9e69e127397 ("netfilter: xtables: don't hook tables by default")
> Signed-off-by: Omar Sandoval <osandov@fb•com>
Whoops, please ignore this, I missed the unlock right before the
table_init call...
prev parent reply other threads:[~2018-10-13 7:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 23:16 [PATCH] netfilter: x_tables: fix missing unlock if table init fails Omar Sandoval
2018-10-12 23:35 ` Omar Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181012233517.GA21784@vader \
--to=osandov@osandov$(echo .)com \
--cc=coreteam@netfilter$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=fw@strlen$(echo .)de \
--cc=kadlec@blackhole$(echo .)kfki.hu \
--cc=kernel-team@fb$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox