From: Jakub Kicinski <jakub.kicinski@netronome•com>
To: Corentin Labbe <clabbe@baylibre•com>
Cc: Gilles.Muller@lip6•fr, Julia.Lawall@lip6•fr, agust@denx•de,
airlied@linux•ie, alexandre.torgue@st•com, alistair@popple•id.au,
benh@kernel•crashing.org, carlo@caione•org, davem@davemloft•net,
galak@kernel•crashing.org, joabreu@synopsys•com,
khilman@baylibre•com, matthias.bgg@gmail•com,
maxime.ripard@bootlin•com, michal.lkml@markovi•net,
mpe@ellerman•id.au, mporter@kernel•crashing.org,
narmstrong@baylibre•com, nicolas.palix@imag•fr, oss@buserror•net,
paulus@samba•org, peppe.cavallaro@st•com, tj@kernel•org,
vitb@kernel•crashing.org, wens@csie•org, cocci@systeme•lip6.fr,
dri-devel@lists•freedesktop.org,
linux-amlogic@lists•infradead.org,
linux-arm-kernel@lists•infradead.org, linux-ide@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-mediatek@lists•infradead.org,
linuxppc-dev@lists.
Subject: Re: [PATCH v3 2/7] include: add setbits_leXX/clrbits_leXX/clrsetbits_leXX in linux/setbits.h
Date: Wed, 24 Oct 2018 15:46:13 -0700 [thread overview]
Message-ID: <20181024154613.3ecc96dc@cakuba.netronome.com> (raw)
In-Reply-To: <1540366553-18541-3-git-send-email-clabbe@baylibre.com>
On Wed, 24 Oct 2018 07:35:48 +0000, Corentin Labbe wrote:
> This patch adds setbits_le32/clrbits_le32/clrsetbits_le32 and
> setbits_le64/clrbits_le64/clrsetbits_le64 in linux/setbits.h header.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre•com>
Did you have a look at all the functions defined in bitfield.h?
(including the magic macro-generated ones?) Perhaps those could be
used here?
I also share the concerns about the non-atomic RMW. Obviously correct
beats short IMHO.
> diff --git a/include/linux/setbits.h b/include/linux/setbits.h
> new file mode 100644
> index 000000000000..c82faf8d7fe4
> --- /dev/null
> +++ b/include/linux/setbits.h
> @@ -0,0 +1,84 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef __LINUX_SETBITS_H
> +#define __LINUX_SETBITS_H
> +
> +#include <linux/io.h>
> +
> +#define __setbits(rfn, wfn, addr, set) wfn((rfn(addr) | (set)), addr)
> +#define __clrbits(rfn, wfn, addr, mask) wfn((rfn(addr) & ~(mask)), addr)
> +#define __clrsetbits(rfn, wfn, addr, mask, set) wfn(((rfn(addr) & ~(mask)) | (set)), addr)
> +#define __setclrbits(rfn, wfn, addr, mask, set) wfn(((rfn(addr) | (set)) & ~(mask)), addr)
> +
> +#ifndef setbits_le32
> +#define setbits_le32(addr, set) __setbits(readl, writel, addr, set)
> +#endif
> +#ifndef setbits_le32_relaxed
> +#define setbits_le32_relaxed(addr, set) __setbits(readl_relaxed, writel_relaxed, \
> + addr, set)
> +#endif
> +
> +#ifndef clrbits_le32
> +#define clrbits_le32(addr, mask) __clrbits(readl, writel, addr, mask)
> +#endif
> +#ifndef clrbits_le32_relaxed
> +#define clrbits_le32_relaxed(addr, mask) __clrbits(readl_relaxed, writel_relaxed, \
> + addr, mask)
> +#endif
> +
> +#ifndef clrsetbits_le32
> +#define clrsetbits_le32(addr, mask, set) __clrsetbits(readl, writel, addr, mask, set)
> +#endif
> +#ifndef clrsetbits_le32_relaxed
> +#define clrsetbits_le32_relaxed(addr, mask, set) __clrsetbits(readl_relaxed, \
> + writel_relaxed, \
> + addr, mask, set)
> +#endif
> +
> +#ifndef setclrbits_le32
> +#define setclrbits_le32(addr, mask, set) __setclrbits(readl, writel, addr, mask, set)
> +#endif
> +#ifndef setclrbits_le32_relaxed
> +#define setclrbits_le32_relaxed(addr, mask, set) __setclrbits(readl_relaxed, \
> + writel_relaxed, \
> + addr, mask, set)
> +#endif
> +
> +/* We cannot use CONFIG_64BIT as some x86 drivers use non-atomicwriteq() */
> +#if defined(writeq) && defined(readq)
> +#ifndef setbits_le64
> +#define setbits_le64(addr, set) __setbits(readq, writeq, addr, set)
> +#endif
> +#ifndef setbits_le64_relaxed
> +#define setbits_le64_relaxed(addr, set) __setbits(readq_relaxed, writeq_relaxed, \
> + addr, set)
> +#endif
> +
> +#ifndef clrbits_le64
> +#define clrbits_le64(addr, mask) __clrbits(readq, writeq, addr, mask)
> +#endif
> +#ifndef clrbits_le64_relaxed
> +#define clrbits_le64_relaxed(addr, mask) __clrbits(readq_relaxed, writeq_relaxed, \
> + addr, mask)
> +#endif
> +
> +#ifndef clrsetbits_le64
> +#define clrsetbits_le64(addr, mask, set) __clrsetbits(readq, writeq, addr, mask, set)
> +#endif
> +#ifndef clrsetbits_le64_relaxed
> +#define clrsetbits_le64_relaxed(addr, mask, set) __clrsetbits(readq_relaxed, \
> + writeq_relaxed, \
> + addr, mask, set)
> +#endif
> +
> +#ifndef setclrbits_le64
> +#define setclrbits_le64(addr, mask, set) __setclrbits(readq, writeq, addr, mask, set)
> +#endif
> +#ifndef setclrbits_le64_relaxed
> +#define setclrbits_le64_relaxed(addr, mask, set) __setclrbits(readq_relaxed, \
> + writeq_relaxed, \
> + addr, mask, set)
> +#endif
> +
> +#endif /* writeq/readq */
> +
> +#endif /* __LINUX_SETBITS_H */
next prev parent reply other threads:[~2018-10-24 22:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 7:35 [PATCH v3 0/7] include: add setbits32/clrbits32/clrsetbits32/setbits64/clrbits64/clrsetbits64 Corentin Labbe
2018-10-24 7:35 ` [PATCH v3 1/7] powerpc: rename setbits32/clrbits32 to setbits_be32/clrbits_be32 Corentin Labbe
2018-10-24 7:35 ` [PATCH v3 2/7] include: add setbits_leXX/clrbits_leXX/clrsetbits_leXX in linux/setbits.h Corentin Labbe
2018-10-24 22:46 ` Jakub Kicinski [this message]
2018-10-24 7:35 ` [PATCH v3 3/7 DONOTMERGE] coccinelle: add xxxsetbits_leXX converting spatch Corentin Labbe
2018-10-24 7:35 ` [PATCH v3 4/7] ata: ahci_sunxi: use xxxsetbitsi_le32 functions Corentin Labbe
[not found] ` <1540366553-18541-5-git-send-email-clabbe-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2018-10-24 7:57 ` Sergei Shtylyov
2018-10-24 7:35 ` [PATCH v3 5/7] net: ethernet: stmmac: dwmac-sun8i: use xxxsetbits_le32 Corentin Labbe
2018-10-24 7:35 ` [PATCH v3 6/7] drm: meson: " Corentin Labbe
2018-10-24 7:35 ` [PATCH v3 7/7] net: stmmac: dwmac-meson8b: " Corentin Labbe
2018-10-24 8:57 ` [PATCH v3 0/7] include: add setbits32/clrbits32/clrsetbits32/setbits64/clrbits64/clrsetbits64 Russell King - ARM Linux
2018-11-15 9:30 ` LABBE Corentin
2018-11-15 9:33 ` Russell King - ARM Linux
2018-11-15 12:24 ` LABBE Corentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024154613.3ecc96dc@cakuba.netronome.com \
--to=jakub.kicinski@netronome$(echo .)com \
--cc=Gilles.Muller@lip6$(echo .)fr \
--cc=Julia.Lawall@lip6$(echo .)fr \
--cc=agust@denx$(echo .)de \
--cc=airlied@linux$(echo .)ie \
--cc=alexandre.torgue@st$(echo .)com \
--cc=alistair@popple$(echo .)id.au \
--cc=benh@kernel$(echo .)crashing.org \
--cc=carlo@caione$(echo .)org \
--cc=clabbe@baylibre$(echo .)com \
--cc=cocci@systeme$(echo .)lip6.fr \
--cc=davem@davemloft$(echo .)net \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=galak@kernel$(echo .)crashing.org \
--cc=joabreu@synopsys$(echo .)com \
--cc=khilman@baylibre$(echo .)com \
--cc=linux-amlogic@lists$(echo .)infradead.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-ide@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linuxppc-dev@lists. \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=maxime.ripard@bootlin$(echo .)com \
--cc=michal.lkml@markovi$(echo .)net \
--cc=mpe@ellerman$(echo .)id.au \
--cc=mporter@kernel$(echo .)crashing.org \
--cc=narmstrong@baylibre$(echo .)com \
--cc=nicolas.palix@imag$(echo .)fr \
--cc=oss@buserror$(echo .)net \
--cc=paulus@samba$(echo .)org \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=tj@kernel$(echo .)org \
--cc=vitb@kernel$(echo .)crashing.org \
--cc=wens@csie$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox