Subject: Re: [PATCH net-next 7/8] net: sched: pie: add derandomization mechanism

From: Stephen Hemminger <[email-masked]>
Date: Wed, 31 Oct 2018 09:38:27 -0700

On Wed, 31 Oct 2018 21:49:31 +0530
Leslie Monis <[email-masked]> wrote:

> diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c
> index b68b367..88e605c 100644
> --- a/net/sched/sch_pie.c
> +++ b/net/sched/sch_pie.c
> @@ -58,6 +58,7 @@ struct pie_vars {
>  	u32 avg_dq_rate;	/* bytes per pschedtime tick,scaled */
>  	u32 qlen_old;		/* in bytes */
>  	bool active;		/* inactive/active */
> +	u64 accu_prob;		/* accumulated drop probability */
>  };
>  

Although putting it at the end seems like a natural place, it creates
holes in the c structure. My recommendation would be to put the new
field after dq_tsstamp.