Subject: Re: [PATCH net-next,v3 12/12] qede: use ethtool_rx_flow_rule() to remove duplicated parser code

From: Marcelo Ricardo Leitner <[email-masked]>
Date: Thu, 22 Nov 2018 14:59:08 -0200

On Wed, Nov 21, 2018 at 03:51:32AM +0100, Pablo Neira Ayuso wrote:
...
>  static int
>  qede_parse_flower_attr(struct qede_dev *edev, __be16 proto,
> -		       struct tc_cls_flower_offload *f,
> -		       struct qede_arfs_tuple *tuple)
> +		       struct flow_rule *rule, struct qede_arfs_tuple *tuple)

What about s/qede_parse_flower_attr/qede_parse_flow_attr/ or so? As it
is not about flower anymore.

It also helps here:

> -static int qede_flow_spec_to_tuple(struct qede_dev *edev,
> -				   struct qede_arfs_tuple *t,
> -				   struct ethtool_rx_flow_spec *fs)
> +static int qede_flow_spec_to_rule(struct qede_dev *edev,
> +				  struct qede_arfs_tuple *t,
> +				  struct ethtool_rx_flow_spec *fs)
>  {
...
> +
> +	if (qede_parse_flower_attr(edev, proto, flow->rule, t)) {
> +		err = -EINVAL;
> +		goto err_out;
> +	}
> +
> +	/* Make sure location is valid and filter isn't already set */
> +	err = qede_flow_spec_validate(edev, &flow->rule->action, t,
> +				      fs->location);
...