Subject: Re: [PATCH] net: usb: aqc111: Properly initialize wol_cfg in aqc111_suspend

From: Nathan Chancellor <[email-masked]>
Date: Wed, 28 Nov 2018 22:54:40 -0700

On Wed, Nov 28, 2018 at 09:52:41PM -0800, David Miller wrote:
> From: Nathan Chancellor <[email-masked]>
> Date: Wed, 28 Nov 2018 22:18:09 -0700
> 
> > Clang warns:
> > 
> > drivers/net/usb/aqc111.c:1326:37: warning: suggest braces around
> > initialization of subobject [-Wmissing-braces]
> >                 struct aqc111_wol_cfg wol_cfg = { 0 };
> >                                                   ^
> >                                                   {}
> > 1 warning generated.
> > 
> > Add another set of braces to initialize the char subobjects as well.
> > 
> > Fixes: e58ba4544c77 ("net: usb: aqc111: Add support for wake on LAN by MAGIC packet")
> > Signed-off-by: Nathan Chancellor <[email-masked]>
> 
> This will in turn make some versions of gcc warn.
> 
> Please just memset() this object, thanks.

I thought this was the form that all compilers seemed to agree on but
sure, I will send a v2.

Thanks for the quick response,
Nathan