Subject: Re: [PATCH] dpaa_eth: Add dpaa_change_carrier()

From: Andrew Lunn <[email-masked]>
Date: Fri, 7 Dec 2018 10:15:22 +0100

On Fri, Dec 07, 2018 at 08:36:48AM +0000, Madalin-cristian Bucur wrote:
> > -----Original Message-----
> > From: Joakim Tjernlund <[email-masked]>
> > Sent: Thursday, December 6, 2018 5:32 PM
> > To: netdev @ vger . kernel . org <[email-masked]>; Madalin-
> > cristian Bucur <[email-masked]>
> > Cc: [email-masked] <[email-masked]>
> > Subject: [PATCH] dpaa_eth: Add dpaa_change_carrier()
> > 
> > This allows to control carrier from /sys/class/net/ethX/carrier
> 
> Hi,
> 
> can you please explain why it's needed?

Hi Madelin

See the patch:

[PATCH] gianfar: Add gfar_change_carrier()

Which is basically the same.

A better approach is being discussed. So for the moment, to stop DaveM
from merging this not knowing it is related to that patch:

NACK

	Andrew