Subject: Re: [net-next PATCH RFC 4/8] net: core: add recycle capabilities on skbs via page_pool API

From: Ilias Apalodimas <[email-masked]>
Date: Sat, 8 Dec 2018 09:54:32 +0200

On Fri, Dec 07, 2018 at 11:15:14PM -0800, David Miller wrote:
> From: Jesper Dangaard Brouer <[email-masked]>
> Date: Fri, 07 Dec 2018 00:25:47 +0100
> 
> > @@ -744,6 +745,10 @@ struct sk_buff {
> >  				head_frag:1,
> >  				xmit_more:1,
> >  				pfmemalloc:1;
> > +	/* TODO: Future idea, extend mem_info with __u8 flags, and
> > +	 * move bits head_frag and pfmemalloc there.
> > +	 */
> > +	struct xdp_mem_info	mem_info;
> 
> This is 4 bytes right?

With this patchset yes

> 
> I guess I can live with this.

Great news!

> 
> Please do some microbenchmarks to make sure this doesn't show any
> obvious regressions.

Will do

Thanks
/Ilias