From: "Maciej Żenczykowski" <zenczykowski@gmail•com>
To: "Maciej Żenczykowski" <maze@google•com>,
"Jeff Garzik" <jgarzik@pobox•com>,
"Ben Hutchings" <ben@decadent•org.uk>
Cc: "David S . Miller" <davem@davemloft•net>,
David Decotigny <decot@google•com>,
netdev@vger•kernel.org
Subject: [PATCH] ethtool: zero initialize coalesce struct
Date: Fri, 14 Dec 2018 17:19:23 -0800 [thread overview]
Message-ID: <20181215011923.246179-1-zenczykowski@gmail.com> (raw)
From: Maciej Żenczykowski <maze@google•com>
prior to fetching it from kernel.
Otherwise we run the risk of very tail portion of it (dmac field)
being left entirely uninitialized, and likely containing some sort
of stale data.
It seems to likely be some sort of time (a second's counter).
Tested:
'ethtool -c eth1' with old kernel now reports 'dmac: 0' where
previously it reported some sort of second counter.
Signed-off-by: Maciej Żenczykowski <maze@google•com>
---
ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ethtool.c b/ethtool.c
index 2f7e96bb58db..465eeecb9318 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -2076,7 +2076,7 @@ static int do_gchannels(struct cmd_context *ctx)
static int do_gcoalesce(struct cmd_context *ctx)
{
- struct ethtool_coalesce ecoal;
+ struct ethtool_coalesce ecoal = {};
int err;
if (ctx->argc != 0)
--
2.20.0.405.gbc1bbc6f85-goog
next reply other threads:[~2018-12-15 1:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-15 1:19 Maciej Żenczykowski [this message]
2018-12-15 2:26 ` [PATCH] ethtool: zero initialize coalesce struct Michal Kubecek
2018-12-15 2:30 ` Maciej Żenczykowski
2018-12-15 12:29 ` Ben Hutchings
2019-01-18 18:40 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181215011923.246179-1-zenczykowski@gmail.com \
--to=zenczykowski@gmail$(echo .)com \
--cc=ben@decadent$(echo .)org.uk \
--cc=davem@davemloft$(echo .)net \
--cc=decot@google$(echo .)com \
--cc=jgarzik@pobox$(echo .)com \
--cc=maze@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox