Subject: Re: [PATCH net] mscc: Register poll timeout should be wall time not attempts

From: Andrew Lunn <[email-masked]>
Date: Thu, 20 Dec 2018 12:31:11 +0100

On Thu, Dec 20, 2018 at 12:11:50PM +0100, Steen Hegelund wrote:
> The 12/20/2018 11:31, Andrew Lunn wrote:
> > On Thu, Dec 20, 2018 at 10:08:16AM +0100, Steen Hegelund wrote:
> > > When doing indirect access in the Ocelot chip, a command is setup,
> > > issued and then we need to poll until the result is ready. The polling
> > > timeout is specified in milliseconds in the datasheet and not in
> > > register access attempts.
> > > 
> > > Signed-off-by: Steen Hegelund <[email-masked]>
> > 
> > Hi Steen
> > 
> > Have you seen real issues with this code? You have marked this for
> > net, indicating it is a bug fix. If it is a real fix, please provide a
> > fixes: tag.
> > 
> > Thanks
> > 	Andrew
> 
> Hi Andrew,
> 
> It is not a bug on the currently supported platform, but we observed
> that the code does not work properly on other platforms that we want to
> support as the timing requirements there are different.  So maybe this
> is rather an improvement than a fix...
> 
> Should this rather go to net-next?

The requirements for stable are listed here:

https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

net-next seems a better fit.

	 Andrew