Subject: Re: [PATCH iproute2 1/1] testsuite: Fix colorize

From: Stephen Hemminger <[email-masked]>
Date: Thu, 20 Dec 2018 20:17:48 -0800

On Tue, 18 Dec 2018 20:29:04 +0100
Petr Vorel <[email-masked]> wrote:

> bash and dash require for escape sequence to use 'echo -e' or printf
> (but working on zsh). Choosing printf as it's implementation is IMHO
> more portable than echo implementations.
> dash also require to use \033[0; as escape sequence instead of \e[0;
> 
> NOTE: \e[0; kept in lib/color.c as it's not problematic for C code
> (working when run ip on various shells).
> 
> Fixes: 7e2f71b4 ("testsuite: colorize test result output")
> 
> Signed-off-by: Petr Vorel <[email-masked]>

Sure applied. Not sure why people expect tests to work without
bash. Next they will want it to work with clang on BSD...